Date: Mon, 9 Jun 2014 19:27:43 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Warren Block <wblock@wonkity.com>, Adrian Chadd <adrian@freebsd.org>, Julio Merino <jmmv@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Turning TESTS on by default Message-ID: <20140609232743.GL1209@hub.FreeBSD.org> In-Reply-To: <20140609231506.GM3991@kib.kiev.ua> References: <CAFY7cWB=BOKWh4gK=wwgvhnAoVUuVBOEqk08nXeo7eWwMguZzw@mail.gmail.com> <20140607033334.GO3991@kib.kiev.ua> <CAFY7cWDWSUSYQ01ycnW4Tj4pvDJuBO62Zt_LOJnK66NaJQt_%2BQ@mail.gmail.com> <alpine.BSF.2.00.1406081145280.11322@wonkity.com> <CAFY7cWAt16EGmOfcfDLLh9Y0W5o5u0eU__2Nj_iu1sQyNuP9vw@mail.gmail.com> <CAJ-VmokUB=xogy%2BxdsBQ746y3vWyMsqWR9aZty5gGathKhbJhw@mail.gmail.com> <20140608203645.GD33882@hub.FreeBSD.org> <20140609231506.GM3991@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--hdW7zL/qDS6RXdAL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jun 10, 2014 at 02:15:06AM +0300, Konstantin Belousov wrote:
> On Sun, Jun 08, 2014 at 04:36:45PM -0400, Glen Barber wrote:
> > On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote:
> > > Now, as for how much bloat it adds to the CD images...
> > >=20
> >=20
> > Enough that it will be turned off for the CDs.
>=20
> I wanted to answer that we should split the question into two,
> one is whether to enable tests installation by default for buildworld
> (and I answered no there), another is whether to ship tests with the
> installation media, both on releases and snapshots.
>=20
> I think that we should do the later, if not on CD, then on DVD and for
> ftp installs. This would mean that there is one more customization
> for the release build process, but I do not think that the release
> build structure requires significant changes.
>=20
We are dangerously teetering every time an option to add "just one more"
thing to the CD is committed to being unable to fall below the 685MB
size (which I understand is what FreeBSDMall needs for the CDs they
produce).
So, as our src/ and ports/ trees grow, the room we have left is
shrinking fast. I think it is not feasible to ship the tests on the CD,
but I do agree they can be shipped on the DVD.
Julio has submitted a review request for this to make a tests.txz
distribution, which can then be excluded for the bootonly.iso and
disc1.iso, but kept for the dvd.iso.
https://phabric.freebsd.org/D198
I am building a test release build with this change now, but I am aware
of one immediate problem that will be encountered - if we default
WITH_TESTS=3D1, the running userland on the bootonly.iso and disc1.iso
(used for the installer) will also include the tests.
This is because we do not evaluate the value of WITH_TESTS=3D, but only
that it is defined. This is also a problem for the debug.txz with
WITH_DEBUG_FILES=3D1 for the buildworld/buildkernel, but
WITHOUT_DEBUG_FILES=3D1 for the bootonly.iso and disc1.iso creation,
because we cannot set both.
Some of the later commits to a projects/ branch to work on allowing the
debug.txz to be fetched from FTP (or via the netinstall) illustrates the
problem and some very hackish workarounds I have tried.
https://svn.freebsd.org/base/projects/release-debugdist/
Glen
--hdW7zL/qDS6RXdAL
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJTlkLvAAoJELls3eqvi17Qf0kQAJ2a4SjAtbGQOJ3Z59La/Oex
/uTs8GDYs2eTrGuRwWTy6ZyIab3eL272SVaJvI1m/F1UIjOnfwBTg9n60pPdUinO
qJduZVQc9+dWPEM1cAcfd+gQH2VnAZZHKXxssrFusSlkmANWdLuV7IxnmVQ+U6C4
GjU+k9KYN7wnftNzQd1Su/GOZmCRMiniijQa0Z7y557hyBgGQ8eUoxgv+tyvVdMa
R6BUP9ClNRU9Fg+SWE1bOn3bTvKWOl9O0WstegzK98iX2YnRjOSZJqlZAjnSKmlb
EymnnOJWjqsCbTXzbsi+7I8RVKyMRytFNdqgXnnvUagLgmQLPV96NIEI3oSXm12W
dfgP4aSZjpoTCiE43yjxbjWAXIvGF9ZKa+NB2C05eUsxUOqvdjY1Ikb8m8usNpUd
MIaQMwmPj8s4fItrSW7wxNoF1nqtAHZhGkJXKY7hdUi97yZdCsdR9mBpu14k0ujO
CETtokmO43IZqx0PFLW+Eny5KpQek488vnG7cTyOngMrTdfSSNUEkuFfohysEJcF
EfmY7MUGMF1bXKBq1xojqwNXEaxrSacfU0AiKkjxe3qBua0z/uxZWHfhJnjnNRNZ
PRtJOMgxTBrfEz8ma3nZxzujlDBM4rtJN1zPLgIPprBMmWmImPr3/zrN3n0YhGZu
r5wPBM6SClmahm4rEN+r
=Gqrc
-----END PGP SIGNATURE-----
--hdW7zL/qDS6RXdAL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140609232743.GL1209>