Date: Mon, 3 Nov 2014 09:41:29 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Julian Elischer <julian@freebsd.org> Cc: freebsd-hackers@freebsd.org, Tiwei Bie <btw@mail.ustc.edu.cn> Subject: Re: [PATCH] Finish the task 'sysctl reporting current working directory' Message-ID: <20141103084129.GF29497@dft-labs.eu> In-Reply-To: <5457394E.4050905@freebsd.org> References: <1414987325-23280-1-git-send-email-btw@mail.ustc.edu.cn> <20141103051908.GC29497@dft-labs.eu> <20141103064052.GA1739@freebsd> <5457394E.4050905@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 03, 2014 at 04:14:06PM +0800, Julian Elischer wrote: > On 11/3/14, 2:40 PM, Tiwei Bie wrote: > >On Mon, Nov 03, 2014 at 06:19:08AM +0100, Mateusz Guzik wrote: > >>On Mon, Nov 03, 2014 at 12:02:05PM +0800, Tiwei Bie wrote: > >> > >>>@@ -657,6 +657,7 @@ TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_entry); > >>> #define KERN_PROC_UMASK 39 /* process umask */ > >>> #define KERN_PROC_OSREL 40 /* osreldate for process binary */ > >>> #define KERN_PROC_SIGTRAMP 41 /* signal trampoline location */ > >>>+#define KERN_PROC_CWD 42 /* process current working directory */ > >>> > why are you using a fixed sysctl MIB number? > I thought we were moving towards dynamic sysctls when we add new ones. > We are? KERN_PROC_* seems to be a complete list with SIGTRAMP added last year. I guess we can do it with OID_AUTO, if there will be any need we can switch it back to a static var. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141103084129.GF29497>