Date: Sat, 17 Jan 2015 15:09:36 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Palle Girgensohn <girgen@pingpong.net> Cc: "pgsql@FreeBSD.org" <pgsql@FreeBSD.org>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org>, Waitman Gobble <gobble.wa@gmail.com> Subject: Re: postgresql93 port and libedit Message-ID: <20150117140935.GQ98528@ivaldir.etoilebsd.net> In-Reply-To: <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net> References: <CAFuo_fzX5i357NofZ2DFkz_=qDZzdNdGKdT8RfhoTN-wo=YDSA@mail.gmail.com> <20150115160113.GE98528@ivaldir.etoilebsd.net> <CAFuo_fxXu05ELWtB3GSjhC0-fk_cjEv8QN4LTgyxdsaC%2BXLXow@mail.gmail.com> <20150117004151.GO98528@ivaldir.etoilebsd.net> <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Pes7OZCOzfZhFQfq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Jan 17, 2015 at 10:37:49AM +0100, Palle Girgensohn wrote:
>=20
>=20
> 17 jan 2015 kl. 01:41 skrev Baptiste Daroussin <bapt@freebsd.org>:
>=20
> > On Thu, Jan 15, 2015 at 08:02:22PM -0800, Waitman Gobble wrote:
> >> On Thu, Jan 15, 2015 at 8:01 AM, Baptiste Daroussin <bapt@freebsd.org>=
wrote:
> >>> On Wed, Jan 14, 2015 at 10:27:14PM -0800, Waitman Gobble wrote:
> >>>> Hi,
> >>>>=20
> >>>> I noticed that postgresql93-client port pulls in readline, which is =
GPLv3.
> >>>> When I get rid of readline in Makefile 'USES' and also change the
> >>>> bottom of the Makefile in postgresql93-server,
> >>>>=20
> >>>> ...
> >>>> .include "${.CURDIR}/../postgresql92-server/Makefile"
> >>>>=20
> >>>> CONFIGURE_ARGS+=3D--with-libedit-preferred
> >>>>=20
> >>>>=20
> >>>> It builds without readline and links against libedit in base:
> >>>>=20
> >>> except that libedit is not really an alternative as it does not suppr=
ot unicode
> >>> (except in head) one solution would be to try linking against the edi=
tline port
> >>> which contains the same fixes as libedit in head and see if it works.
> >>>=20
> >>> Best regards,
> >>> Bapt
> >>=20
> >> Thanks so much for the feedback. I've considered the options regarding
> >> my project and I think it's more work to handle end-user devices with
> >> a pkg repository if I indeed must manage custom ports built using
> >> customized sources. Distributing the initial appliance isn't the
> >> problem, i'm working out an update strategy for down the road.
> >>=20
> >=20
> > https://people.freebsd.org/~bapt/pglibedit.diff
> >=20
> > This patch works for me and accepts perfectly unicode.
> >=20
> > Can anyone from the postgresql team test, generalize to other postegres=
ql
> > versions? (please keep it using the port version of libedit).
> >=20
> > Best regards,
> > Bapt
>=20
> Hi,
>=20
> Looks like a reasonable patch. I have a hard time finding the differences=
between readine and ilbedit. It aims at 100% API compatibility. How good i=
s libedit? If it degrades functionality compared to readline it should real=
ly be an option, but I agree, lesser options are preferred.=20
>=20
> Palle
It is not 100% compatible but I think it implements all pgsql requirements,=
only
the version in ports and he head handle correctly unicode.
Some of the default settings are a bit different most ^W but that can be ch=
anged
via .editrc
mysql has tips about the differences:
https://docs.oracle.com/cd/E17952_01/refman-5.6-en/mysql-tips.html
=46rom what I can read in the code psql only uses compatible interfaces.
As the one who have done the latet updates on libedit both base and ports, I
would recommand to only use the version from ports on all version of FreeBS=
D as
I can add quick fixes if needed.
Once I'm sure the libedit in base is good enough everywhere we would be abl=
e to
switch on the base version if people prefers to avoid an external dep.
Best regards,
Bapt
--Pes7OZCOzfZhFQfq
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEABECAAYFAlS6bR0ACgkQ8kTtMUmk6EwAIwCfRLBwBfzzBlxaucaBfUMU0d0f
KcgAnjKATPDAJ0szNqQ6FrnOLjixYpbV
=rudY
-----END PGP SIGNATURE-----
--Pes7OZCOzfZhFQfq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150117140935.GQ98528>