Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 May 2015 10:50:30 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: libc/gen: unused variables
Message-ID:  <20150520075030.GJ2499@kib.kiev.ua>
In-Reply-To: <CAJ-Vmok3-tDX-9X4NOjghoX40BQpF12XPL9S%2B=bsY5pkYuP39w@mail.gmail.com>
References:  <CAJ-Vmok3-tDX-9X4NOjghoX40BQpF12XPL9S%2B=bsY5pkYuP39w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 20, 2015 at 12:11:08AM -0700, Adrian Chadd wrote:
> Hi,
> 
> here's a patch against -head that eliminates gcc-4.9 complaining about
> set-but-unused variables. It just comments them out for now - are
> these okay to eliminate, or is there something else that's
> broken/missing?
Of course, the patch as posted must not be committed.

For dl_init_phdr_info(), it is acceptable to eliminate AT_PHENT case
and phent local.

I have not looked at the other places.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150520075030.GJ2499>