Date: Mon, 13 Jul 2015 17:51:43 +0900 (JST) From: Kohji Okuno <okuno.kohji@jp.panasonic.com> To: hps@selasky.org Cc: freebsd-current@freebsd.org, mav@FreeBSD.org, okuno.kohji@jp.panasonic.com Subject: Re: Why shoud we cause panic in scsi_da.c? Message-ID: <20150713.175143.290106286605820529.okuno.kohji@jp.panasonic.com> In-Reply-To: <55A37933.3000802@selasky.org> References: <20150709.150520.1823457260978955949.okuno.kohji@jp.panasonic.com> <20150713.171110.531869520391748650.okuno.kohji@jp.panasonic.com> <55A37933.3000802@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi HPS,
Thank you for your comment.
I will wait for the commnet.
Kohji Okuno
> On 07/13/15 10:11, Kohji Okuno wrote:
>> Hi,
>>
>> Could you comment on my quesion?
>>
>> Best regards,
>> Kohji Okuno
>>
>>> Hi,
>>>
>>> I found panic() in scsi_da.c. Please find the following.
>>> I think we should return with error without panic().
>>> What do you think about this?
>>>
>>> scsi_da.c:
>>> 3018 } else if (bp != NULL) {
>>> 3019 if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0)
>>> 3020 panic("REQ_CMP with QFRZN");
>>>
>
> Hi,
>
> It looks to me more like an KASSERT() is appropriate here.
>
> Might be some people which can answer this are on vacation currently.
>
> --HPS
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150713.175143.290106286605820529.okuno.kohji>