Date: Thu, 13 Aug 2015 08:18:02 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: Bruce Simpson <bms@fastmail.net>, Davide Italiano <davide@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r286484 - projects/collation/usr.bin/localedef Message-ID: <20150813061802.GA62875@ivaldir.etoilebsd.net> In-Reply-To: <20150813114425.X996@besplex.bde.org> References: <201508082257.t78MvIT1000841@repo.freebsd.org> <CACYV=-GnOpPddd-x_J0yW4g4QFsdcEVXaVc9CER9JD7iObGzAg@mail.gmail.com> <20150812182739.GB51754@ivaldir.etoilebsd.net> <55CB91FD.8000004@fastmail.net> <20150813114425.X996@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Aug 13, 2015 at 12:16:41PM +1000, Bruce Evans wrote:
> On Wed, 12 Aug 2015, Bruce Simpson wrote:
>=20
> > On 12/08/15 19:27, Baptiste Daroussin wrote:
> >> On Wed, Aug 12, 2015 at 01:22:17PM -0400, Davide Italiano wrote:
> >>>> +#define RB_NUMNODES(type, name, head, cnt) do { \
> >>>> + type *t; \
> >>>> + cnt =3D 0; \
> >>>> + RB_FOREACH(t, name, head) { \
> >>>> + cnt++; \
> >>>> + } \
> >>>> +} while (0);
> >>>> +
> >>>=20
> >>> Can you commit this one to HEAD && move it to the right header?
>=20
> This has too many bugs to commit.
FYI the version proposed for tree(3):
#define RB_COUNT(x, name, head, cnt) do { \
(cnt) =3D 0; \
RB_FOREACH((x), name, (head)) { \
(cnt)++; \
} \
} while (0)
Bapt
--45Z9DzgjV8m4Oswq
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlXMNpoACgkQ8kTtMUmk6Ewf5ACfZ3EGD8jQN678E5gWpn0kKnIr
YYMAn3Nx8G6EKUn4txEk7r5OYp0xvABV
=n4qP
-----END PGP SIGNATURE-----
--45Z9DzgjV8m4Oswq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150813061802.GA62875>