Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Feb 2016 23:32:38 +0100
From:      Jilles Tjoelker <jilles@stack.nl>
To:        John Baldwin <jhb@freebsd.org>
Cc:        freebsd-arch@freebsd.org
Subject:   Re: Refactoring asynchronous I/O
Message-ID:  <20160211223238.GA73182@stack.nl>
In-Reply-To: <2604669.yblYTI1T32@ralph.baldwin.cx>
References:  <2793494.0Z1kBV82mT@ralph.baldwin.cx> <20160210225844.GA89743@stack.nl> <1897781.JF7dmmKAT1@ralph.baldwin.cx> <2604669.yblYTI1T32@ralph.baldwin.cx>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 10, 2016 at 04:21:30PM -0800, John Baldwin wrote:
> I've pushed a new version with a vfs.aio.enable_unsafe sysctl
> (defaults to off).  If you think this is ok then I'll work on cleaning
> up some of the module bits (removing the unload support mostly).  I
> figure marking the syscalls as STD and removing all the helper stuff
> can be done as a followup commit to reduce extra noise in this diff
> (which is large enough on its own).

> https://github.com/freebsd/freebsd/compare/master...bsdjhb:aio_rework

> (Also, for the inital commit I will leave out the socket protocol
> hook.  That can be added later.)

Looks good to me, except that the error should be [ENOTSUP] instead of
the overloaded [EINVAL].

-- 
Jilles Tjoelker



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160211223238.GA73182>