Date: Fri, 25 Nov 2016 15:57:25 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: Alan Somers <asomers@freebsd.org>, FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: NFSv4 performance degradation with 12.0-CURRENT client Message-ID: <20161125135725.GD54029@kib.kiev.ua> In-Reply-To: <YTXPR01MB018969FB21212700C4043AEADD890@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM> References: <CAOtMX2jJ2XoQyVG1c04QL7NTJn1pg38s=XEgecE38ea0QoFAOw@mail.gmail.com> <20161124090811.GO54029@kib.kiev.ua> <YTXPR01MB0189E0B1DB5B16EE6B388B7DDDB60@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM> <CAOtMX2hBXAJN_udED-u5%2B6UznR2%2BW88xgb=RqKSZL65Z3%2BcKOw@mail.gmail.com> <YTXPR01MB0189C3E11821E4F7B7DF1814DDB60@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM> <20161125084106.GX54029@kib.kiev.ua> <YTXPR01MB018969FB21212700C4043AEADD890@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 25, 2016 at 12:54:07PM +0000, Rick Macklem wrote: > Well, ideally theer would be a VOP_MMAPDONE() or something like that, which > would tell the NFSv4 client that I/O is done on the vnode so it can close it. > If there was some way for the NFSv4 VOP_CLOSE() to be able to tell if the file > has been mmap'd, that would help since it could close the ones that are not > mmap'd on the last descriptor close. > (A counter wouldn't be as useful, since NFSv4 would have to keep checking it to > see if it can do the close yet, but it might still be doable.) I thought that the issue was in tracking any opens and mmaps, but from this reply it is not that clear. Do you need callback when all opens and mmaps have ended, or only opens and mmaps for write ? If later, we already have a suitable mechanism VOP_ADD_WRITECOUNT().
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161125135725.GD54029>