Date: Tue, 13 Dec 2016 14:29:19 +0000 From: freebsd xen <roger.pau@citrix.com> To: liuyingdong <liuyingdong@huawei.com> Cc: <freebsd-xen@freebsd.org>, <zhao.zhaojun@huawei.com>, <suoben@huawei.com>, <ouyangzhaowei@huawei.com> Subject: Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again Message-ID: <20161213142919.ulvvvwoz2da5fedw@dhcp-3-221.uk.xensource.com> In-Reply-To: <584F8F1C.6030006@huawei.com> References: <5825272C.3010704@huawei.com> <584F8F1C.6030006@huawei.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 13, 2016 at 02:03:08PM +0800, liuyingdong wrote: > Hello Roger, > I want to know how about this patch,Please let me know if you have any questions. > Thanks. Hello, Thanks for the patches! This one is looking fine, it's just that I'm a little bit busy at the moment, and there are some issues in HEAD related to Xen that I would like to fix before pushing anything new. In any case, I see that you are sending the patches using Thunderbird, which is not ideal (MUAs tend to mangle patches). The preferred way for sending patches is using "git send-email"[0] directly. There are also several tutorials online that will help you setup git send-email correctly. If there's some reason why you can't use git send-email I would recommend that you also attach the patches directly to emails, that way they won't probably get mangled. Roger. [0] https://git-scm.com/docs/git-send-email
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161213142919.ulvvvwoz2da5fedw>