Date: Fri, 5 May 2017 12:20:06 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Franco Fichtner <franco@lastsummer.de>, FreeBSD Mailing List <freebsd-ports@freebsd.org>, Aristedes Maniatis <ari@ish.com.au> Subject: Re: diff and submissions Message-ID: <20170505102006.5lzf6kt7rotzvzeg@ivaldir.net> In-Reply-To: <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--xsx5zy74qnh3jn6n Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote: > Le 05/05/2017 =E0 08:16, Franco Fichtner a =E9crit : > >> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: > >> > >> If you went as far as being able to create a pull request, you can do a > >> git show HEAD or git diff origin/trunk...HEAD and submit that in the > >> FreeBSD PR as well. > > It's pretty easy to extract the diff from a PR on GitHub, just append > > ".diff", and ".patch" works too, but gives the full git commit history: > > > > https://github.com/freebsd/freebsd-ports/pull/62.diff >=20 > Yes, I am aware of that, the problem with github pull requests is that > they are outside of the FreeBSD bug report process, they do not get > assigned to maintainers, nobody notices them, they just stay there, and > get obsolete. > There have been 61 before, yes, I closed a lot because they were > obsolete because it is outside of our process and nobody noticed them, > and for the rest either asked the submitter to open a PR on our > bugzilla, or opened one myself. >=20 I made a script which is a few lines of shell that converts pull requests to phabricator reviews automatically. I have handed it to some of the phabricator admins, I hope it will be progr= ess soon. Bapt --xsx5zy74qnh3jn6n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlkMUdQACgkQY4mL3PG3 PlpE2BAAtYLcXR8Ta98RfY71Flw/eBFk1R6klmwKzoB0BH6zPSFhzeoMAXGydZSu /8+QNdMiY5t6oIb4Kdt31BbBZ7ANgOxVLhfDbHVuWGQrVKLhvp/ZbJvI/vV2DrCr onvxpp+D8ARpAEhGlATXoO7/HHEQ3QcBxnVWQIVpqNygY+IG5yGq65SR1PKs+PJa zQvWH6iBP3z3wFJwAiRQs4De3UM1FGwkC3BTgAfPoRkL77F/sXxIbWWI6WGAJE5a /S+z73vkEIkqAppLZd5MHeBxjTM703Godl9ZxYqIgPFyyjwQFhUsShab7rMvBLLk X9lKqXIoz/PrRDzW6TzXh+SEqQoGvqxsiA0BgmnbaIdQpuGOs1Cyj+2lnlyhmvRh /Ewip30egXjyYOjhvxUe+ii+KGfm8EI8i0HL7WOqobquOIFqDeccCVMchW0RR7Ua jaDEamCCFpBWRvm8pUPVhqkLsM3AHdTu4EWrXkrjdot+I8fo0tANEzRYwQAHqwlS 76KH3asnOEIpAvyIOAa1XhINOU9RAHjhQTPruUq0/rPWgqwD6lfiM7Mcg1QcgTW1 wFNN0PGUXNpHyOjbG//NDmzmNQmJMyRVDbaJ4QZTL5bqNft0Ep/GxdJDTgrkPlaN T8H775eLpLIsiZfQuKUxtfDVil4ju/y1AN0BkgFnKSjxnhctMI0= =S0pJ -----END PGP SIGNATURE----- --xsx5zy74qnh3jn6n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170505102006.5lzf6kt7rotzvzeg>