Date: Fri, 5 May 2017 12:37:45 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Franco Fichtner <franco@lastsummer.de>, FreeBSD Mailing List <freebsd-ports@freebsd.org>, Aristedes Maniatis <ari@ish.com.au> Subject: Re: diff and submissions Message-ID: <20170505103745.sa4oeq573szssqn4@ivaldir.net> In-Reply-To: <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org> References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> <20170505102006.5lzf6kt7rotzvzeg@ivaldir.net> <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--hqcellsomafhgqmy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2017 at 12:27:13PM +0200, Mathieu Arnold wrote: > Le 05/05/2017 =E0 12:20, Baptiste Daroussin a =E9crit : > > On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote: > >> Le 05/05/2017 =E0 08:16, Franco Fichtner a =E9crit : > >>>> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: > >>>> > >>>> If you went as far as being able to create a pull request, you can d= o a > >>>> git show HEAD or git diff origin/trunk...HEAD and submit that in the > >>>> FreeBSD PR as well. > >>> It's pretty easy to extract the diff from a PR on GitHub, just append > >>> ".diff", and ".patch" works too, but gives the full git commit histor= y: > >>> > >>> https://github.com/freebsd/freebsd-ports/pull/62.diff > >> Yes, I am aware of that, the problem with github pull requests is that > >> they are outside of the FreeBSD bug report process, they do not get > >> assigned to maintainers, nobody notices them, they just stay there, and > >> get obsolete. > >> There have been 61 before, yes, I closed a lot because they were > >> obsolete because it is outside of our process and nobody noticed them, > >> and for the rest either asked the submitter to open a PR on our > >> bugzilla, or opened one myself. > >> > > I made a script which is a few lines of shell that converts pull reques= ts to > > phabricator reviews automatically. > > > > I have handed it to some of the phabricator admins, I hope it will be p= rogress > > soon. >=20 >=20 > Please, do not do that. >=20 > Phabricator is for code review, not bug reports. It all ends up in our > repository, but Phabricator does not have any maintainer notification > like Bugzilla has. > robak@ has a script that does pull-request -> bugzilla, and it has been > waiting for months for someone with access to do something about it. >=20 Pull request are for code submissions and phabricator is the equivalent for= that Bapt --hqcellsomafhgqmy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlkMVfcACgkQY4mL3PG3 PlrePw/8C/8u8nVdAK5ssGoGsnDMdnW4Z4nbOOo8mLTXTucDFnLB49yoAL9EoCPb JVwkpRQ8dyDSgi+GzMzAqk66rnzqMn4f4VDXxTjXTAlgox2uHlfJiGICcd8XOVEL OJLd3ePhprH1p/qlJ1K833PWsnExr+4+QmfO5oVMvV7gleZeICWK3ZgFV6Tylr9t lVFcVN1t2Ps5lmqEZV+3jWYJfierceCp6vOiAt6u8pRZ9ufmradU6hcen4fA1+4w mvMX1miO16orr5NTyt7TIvX3PlQPKk7+30yWWdXBy8z4By+KrM5i6NYT/In/VwAQ H875eoktQexji3/1NzmreBFgGNvKWSZppUQXHlf+jngD/ohUASyMJXP6uasRiE2u AaRIrIAcepfXksHyvueXtGR6lPNjlhlY8HV1l/X0ZQ4TkwSEHuqnPMYWe8hHNjRb 8fUe2s3t3/zokIHdPgRTeI8ziQYJEfT9NAoGyMbVQNVuAwzwgdLvfOMhbIHOnayu r4LwicgZ/r2o7vt6h5hGuU7ceVoGpKqTu60VvIUQvHRbPXos95DvHzWcmSqVRfqn NfVXLYzYtEpa/HvXU3HNDQ4FV13l2tMKKVrjBHordDKg0vIwuOULULH/DITSa1vY igJGK8egK5R1AMl22tEpBv3PZ66Qe4PllXOrDVrn/vkYFNtf/0Q= =LMre -----END PGP SIGNATURE----- --hqcellsomafhgqmy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170505103745.sa4oeq573szssqn4>