Date: Mon, 1 Jan 2018 08:52:57 -0800 (PST) From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> To: Larry McVoy <lm@mcvoy.com> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: Is it considered to be ok to not check the return code of close(2) in base? Message-ID: <201801011652.w01GqvCx087076@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20180101161817.GF4678@mcvoy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, Jan 01, 2018 at 04:14:33PM +0000, Poul-Henning Kamp wrote: > > But this is bikeshedding at this point anyway. > > +1 Bike shedding is good, people learn things from it. I never knew that assert was altered by NDEBUG for example, thanks for that enlightenment Mark. Didnt even realize that assert had been bastardized by standards, and phk is right, it predates all those things, probably by a decade or more. In summary, given the original question, it would be in the interest of the project to evaluate those close() calls that do not check for errors and do something about it. Either document the intent to intentionally ignore them, or handle the error in some fasion. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801011652.w01GqvCx087076>