Date: Wed, 5 Jun 2019 21:05:52 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: Regression test for vn_io_fault Message-ID: <20190605180552.GX75280@kib.kiev.ua> In-Reply-To: <CAOtMX2hocYE0qwhMttO3T0ZK4ghoXZxcFYO=ZzxTRiuWCCWCmw@mail.gmail.com> References: <CAOtMX2hocYE0qwhMttO3T0ZK4ghoXZxcFYO=ZzxTRiuWCCWCmw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 05, 2019 at 10:29:35AM -0600, Alan Somers wrote: > r236321 added vn_io_fault(), a mechanism for avoiding lock order > reversals when a process reads from one file into a mmap()ed buffer > backed by another file. From the description in the comments of > vn_io_fault() it seems like it would be possible to write a reliable > test that would trigger the LOR. But I can't find any evidence in > svn, or bugzilla of such a test program. None in Phabricator either, > which probably wasn't even running when that commit was made. Did > anybody ever write a test program? If so, I volunteer to ATFify it. The test program is in tools/test/upsdl. I object against removing non-atf version on principle, atf tests are not debuggable. Also this is racing test, so it is not as simple as doing N runs where N is fixed. Anyway, test for the ups@ race is included into stress2, where it belongs.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190605180552.GX75280>