Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jul 2019 22:04:00 -0700
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        freebsd-current@freebsd.org
Cc:        markj@freebsd.org
Subject:   Re: vm_page_hold() and drm-legacy-kmod
Message-ID:  <20190709050400.GA63317@troutmask.apl.washington.edu>
In-Reply-To: <20190709044336.GA63186@troutmask.apl.washington.edu>
References:  <20190709043058.GA63004@troutmask.apl.washington.edu> <20190709043505.GC63004@troutmask.apl.washington.edu> <20190709044336.GA63186@troutmask.apl.washington.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 08, 2019 at 09:43:36PM -0700, Steve Kargl wrote:
> On Mon, Jul 08, 2019 at 09:35:05PM -0700, Steve Kargl wrote:
> > On Mon, Jul 08, 2019 at 09:31:12PM -0700, Steve Kargl wrote:
> > > It seems the recent flurry of vm commits has
> > > broken the graphics/drm-legacy-kmod port.
> > > vm_page_hold() no longer exists.  How do I
> > > fix the port?
> > > 
> > 
> > Whoops.  The missing function is vm_page_unhold().
> > Anywhoo, how do I fix this?
> > 
> The code in question is 
> 
>         for (i = 0; i < vsg->num_pages; i++) {
>                 m = vsg->pages[i];
>                 vm_page_lock(m);
>                 vm_page_wire(m);
>                 vm_page_unhold(m);
>                 vm_page_unlock(m);
>         }

This was broken by r349846 committed by markj.

-- 
Steve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190709050400.GA63317>