Date: Wed, 7 Aug 2019 21:14:48 +0100 From: tech-lists <tech-lists@zyxst.net> To: freebsd-arch@freebsd.org Subject: Re: svn commit: r350550 - head/share/mk Message-ID: <20190807201448.GA42725@bastion.zyxst.net> In-Reply-To: <20190806165614.GA41295@FreeBSD.org> References: <201908030106.x7316Ibx078529@repo.freebsd.org> <20190806165614.GA41295@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Tue, Aug 06, 2019 at 04:56:14PM +0000, Glen Barber wrote: >I would like to request this commit be reverted. While the original >commit message to enable this knob stated the commit would be reverted >after stable/12 branched, I have seen no public complaints about >enabling REPRODUCIBLE_BUILD by default (and quite honestly, do not see >the benefit of disabling it by default -- why wouldn't we want >reproducibility?). > >To me, this feels like a step backwards, with no tangible benefit. >Note, newvers.sh does properly detect a modified tree if it can find >the VCS metadata directory (i.e., .git, .svn) -- I know this because >I personally helped with it. > >In my opinion, those that want the non-reproducible metadata included in >output from 'uname -a' should set WITHOUT_REPRODUCIBLE_BUILDS in their >src.conf. Turning off a sane default for the benefit of what I suspect >is likely a short list of use cases feels like a step in the wrong >direction. Well, my use case is that I have some machines that follow 12-stable. I'm not a developer. But I keep an eye on things like security bulletins etc and when they come out it usually gives something like 'affecting 12-STABLE prior to r<number> something like that. And I can easily look at uname -a to see if this or that 12-stable machine needs to be patched or whatever. That is, if reproductible_build is turned off. (or without_reproductible_build is turned on)=20 Or if I mail to stable@ asking for help I'll want to say *exactly* what sources I've built from. And sometimes someone will say "oh that was fixed after r<suchandsuch>" and so I'll grab sources after that revision=20 if I can and fix the problem. But like I say I'm not a dev. I'd guess, though, that lots of non-devs=20 use the revision info if they follow -stable, so if I'm right in thinking= =20 this, it'd be a short list of use cases but lots of affected people. unless there's another way to get the svn rev number? Why turn off this functionality by default? --=20 J. --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8n3tWhxW11Ccvv9/s8o7QhFzNAUFAl1LMSMACgkQs8o7QhFz NAU4xBAAh8VrhAoR/9icuzCvBWyh8KAAgrIZEbBM+qXyRDI0bDD41U3r1XRGfuKo 7/3TvaJipRhtXv0VPRdo495Plq9gUX/9uQzoMsd7p0gtZ/4zqu8/+hMrERcwPsrl m9V3upO0J9bVycQb7Wl0jYqPIkttoTa/Jzm/enqJLFCfa29igakOn5Xx9Y/HeCUw chd7I2jm7cwXqz6M7kzt4N+AeR5Cee1LVTfrfWWs8S9nuJMxR1giI1jHrJvpeATn SPk9FhBCKZq0YjXI4RWY9iM2R+PaXz5+VuAdyW58ksCXDL1XY2q0aT0YiVh7lQRP QFNblzjJXAH7dSBlgdWp3KS0aZ0OEd8+fnA0WFU+xuIOrBdF1YLv/l38HXQ1eSOn Phf665cLqPwlJGW+kNUyEaFs1d+MbPsfsiM9FGxC8wAYsVESVTbeE7qioytoyd4Z 7MvBVgqXZw6iIFWXeBYabT4MPlsLvRn0YXWUr1fuINfPN5GsnEvd56cQnipv11tG hTAEe4hIzaKq7gZywaqJshQGb86fHHv/GqJ85Um4fqFqPOubdg1W3a1XcCnpMxDG EPiYCGhbgrOXKYKJF869NSjOv+lBVUHuchm1FRhLqO2kngL84qdHgOTP/WKFbgLh l2E4bhP4KaSj48GmzyedBT3PKjLrqp+Xg1t2/4waDNPxDeefZQU= =CYHZ -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190807201448.GA42725>