Date: Tue, 3 Dec 2019 20:08:37 +0100 From: Gunther Nikl <gnikl@justmail.de> To: Mark Linimon <linimon@lonesome.com> Cc: Jan Beich <jbeich@FreeBSD.org>, freebsd-x11@freebsd.org Subject: Re: mesa: LLVM_DEFAULT usage Message-ID: <20191203200837.00002360@justmail.de> In-Reply-To: <20191202014823.GA26566@lonesome.com> References: <20191201175632.00000bf9@justmail.de> <a78b-didy-wny@FreeBSD.org> <20191202014823.GA26566@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@lonesome.com> wrote: > While not germane to the use of LLVM itself, I firmly believe > that the LLVM_DEFAULT Makevar should never be overridden. It is > set in Mk/bsd.default-versions.mk and thus ought to be set by > user choice. > > Please see: > > https://wiki.freebsd.org/HardcodedLLVMVersions#Ports_That_Redefine_LLVM_VERSION I had a look at this wiki page. The mesa ports only recently switched to use of LLVM_DEFAULT. According to the wiki page you believe the mesa port should have kept its MESA_LLVM_VER. It should use LLVM_DEFAULT as a default value if there are no reasons to use a different value. This seems to be a sane suggestion. I cannot tell if the ports tree should use this idiom. Regards, Gunther
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191203200837.00002360>