Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 16 Jan 2020 20:44:09 +1100
From:      Peter Jeremy <peter@rulingia.com>
To:        Emmanuel Vadot <manu@bidouilliste.com>
Cc:        Kyle Evans <kevans@freebsd.org>, "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>
Subject:   Re: Banana Pi M1 SATA problems
Message-ID:  <20200116094409.GJ25924@server.rulingia.com>
In-Reply-To: <20200113111932.9e8e648733d530b70011456f@bidouilliste.com>
References:  <20200112080247.GF25924@server.rulingia.com> <CACNAnaEx-BDBEQHSWAaEa2ChR7tKHiKi-FTAd3CW4rKO6fQ1%2Bw@mail.gmail.com> <20200113095740.GG25924@server.rulingia.com> <20200113111932.9e8e648733d530b70011456f@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help 

--2NLGdgz3UMHa/lqP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2020-Jan-13 11:19:32 +0100, Emmanuel Vadot <manu@bidouilliste.com> wrote:
>On Mon, 13 Jan 2020 20:57:40 +1100
>Peter Jeremy <peter@rulingia.com> wrote:
>
>> On 2020-Jan-12 09:22:14 -0600, Kyle Evans <kevans@freebsd.org> wrote:
>> >On Sun, Jan 12, 2020 at 2:03 AM Peter Jeremy <peter@rulingia.com> wrote:
>> >> I'm trying to get my (new) Banana Pi M1 to talk to a SATA drive.
>> >> Unfortunately, something is disabling the SATA port.
>> >
>> >Try updating past r356600; earlier than that and probably 12.1-RELEASE
>> >we were shutting down the regulator. hw.regulator.disable_unused=3D0
>> >should also work around it.

Actually, r356600 increases the breakage.  It attaches the regulator
defined by "target-supply" to the ahci device, however there is no
target-supply field on the ahci device in sun7i-a20-bananapi.dts and
the ahci_5v regulator is disabled so achi0 no longer probes.

After I added following patch, the behaviour went returned to the
previous - ahci0 attaches but ahcich0 is disabled.

Index: gnu/dts/arm/sun7i-a20-bananapi.dts
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- gnu/dts/arm/sun7i-a20-bananapi.dts  (revision 356657)
+++ gnu/dts/arm/sun7i-a20-bananapi.dts  (working copy)
@@ -95,6 +95,7 @@
 };
=20
 &ahci {
+       target-supply =3D <&reg_ahci_5v>;
        status =3D "okay";
 };
=20
@@ -252,6 +253,10 @@
=20
 #include "axp209.dtsi"
=20
+&reg_ahci_5v {
+        status =3D "okay";
+};
+
 &reg_dcdc2 {
        regulator-always-on;
        regulator-min-microvolt =3D <1000000>;

>> I need hw.regulator.disable_unused=3D"0" because the BPi powers itself
>> off completely without it.  I am building a new world+kernel at r356657
>> but that will take a while because it has triggered a clang rebuild.
> This problem should be fixed with r356609.

This part does work, thanks.

--=20
Peter Jeremy

--2NLGdgz3UMHa/lqP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl4gMGJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF
QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi
CzTAhxAAhfYmUkLEt7RyefhSLSmDPb9fL5jKuvu2QX9pfwC0enk3J+mSLwzE9jRL
3Romem0uroYed67Sey4qlpWZiWTVS16W1PlKsEMJmj+M63G2POi+CTerYNATLWuD
iBEHKki4iFNRA9yNGviGeQm02pR4XLQacaIuE9gcI01GcaF+a0Q0Eck5CIl8iOiE
IrVp4uv7TFqwS9A8Zw+RBPLQhu1WX355GxoomxD6l+EXu9DfT4PKGKfAIkPq7OUR
8o+5pm7T7DQh/f83LdDBtb/T1qBkCQYorOr9C3kCeyMSzsNuLhZfts0bnEliXiiz
aqNI21Gl7iVLVdQ+ypWg3SSeZRIiwc/qGgW9UU8zYTMbczLo5Dhh9KOBP4JnZJ/g
nzhzLUcvNmooVCvDeFZvxNqxzibRop9+C/JNn6ciwul/MXgbX4Y5QdjMSsupRfOA
PbsmRKbOeuBxam40FNT4lFIW/d+GLoT4AyVBi0qotXFLyKu5AI0crLSqstqT49KK
0g7ZijbH4j5mJAACmaGkCa5vYpLSK/tDq/SpIu8sgH6aJwUXFFG4+qwpWpE29GlP
9u6VkcORnXLIU6TUeXTDgPDt8FR005LLBSCI08qrW39K7MfiyaA+4OylkZ2dQECN
W9QwiQ2pLgFQdYTFIf3NrEA6ombixWYZV0FfgEgC2yOEGpbtFkw=
=eGdx
-----END PGP SIGNATURE-----

--2NLGdgz3UMHa/lqP--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200116094409.GJ25924>