Date: Fri, 17 Apr 2020 18:05:56 +0200 From: =?utf-8?B?UGF3ZcWC?= Jasiak <pawel@jasiak.xyz> To: freebsd-questions@freebsd.org Subject: Arguments format Message-ID: <20200417160556.GA44862@gmail.com>
next in thread | raw e-mail | index | archive | help
--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi!
I have three questions.
1. In sys/mips/mips/autoconf.c we have functions
static void configure_first(dummy)
static void configure(dummy)
static void configure_final(dummy)
and we are not using argument. We are having those functions also in
ricv, arm, arm64, powerpc and x86 and in non of them we are using dummy,
so maybe we can just remove it? Or if it is necessary why we don't mark
it as __unused like in other functions?
2. Above functions have strange definition for arguments.
static void
configure(dummy)
void *dummy;
{
...
}
Why we are not using
static void
configure(void *dummy)
{
...
}
like in other places?
3. In sys/mips/mips/octeon_cop2.c we are having
struct octeon_cop2_state *
octeon_cop2_alloc_ctx()
{
...
}
but it's declaration in sys/mips/include/octeon_cop2.h is
struct octeon_cop2_state* octeon_cop2_alloc_ctx(void);
Question is if we should change octeon_cop2_alloc_ctx() into
octeon_cop2_alloc_ctx(void)?
I will be happy to help with creating patches.
Thanks!
--=20
Pawe=C5=82 Jasiak
--azLHFNyN32YCQGCU
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEENIqkLxDcCMlLMdi0FzfmQudzVTgFAl6Z0+QACgkQFzfmQudz
VThppw/+ObyczsMDZR1w4C2suW3qysvt0oiiVk0tSNvssaa1AAKzoZZBG9wFt4z4
BIdKjdEKQCrUjHvMRM62eJQArfrvyqPrxzZW++D72FeacvBZQzM4wyGcmifKVbip
yySvz4H060YSuYNMPqDWr4MOE+7w7VjY+FkDvoKP9p0d1X8kuGRCZktxuzrO/f5e
iEvKHhlXYNiwHoSBbUepR/uu7/mBJrYvvJ7R82VPnW6Yow77yFbQzCheDCV5Hkax
sMCa1u5aEW6ueXypZ+g6F7zHm6IhJ0mHuPVDFf9cW8VXF2AMzokJe5Tspf2fuFdu
TQG/rYJgJtJMF3CKYyCm0TZZq3rH9oOysD5mSKEPEd6uLRYnRf46/53bCtD8O/Ga
s8uVs7b984lD+SLMcQ6Qv9yhkxDERi9T0n8nGX8UlGlR8UeJXeijodqEeja85kGk
OTWTMboAs87YADmnU/ZRY+m0fTpiHL+2OVr8xbnXIDGWUcIghnYAn4RP8f1HsCUB
vJL4p/VIEDNWwmvVLXMBv31mz9roifes+vl43bTla+IzzzH19LwsdWcoDyHhjhrL
6hhzYfGjIFJswfmfI1MObQpwP1DjCEl6zW8nvtCZUg8eTvezgxlf1q3RIB4L/cDz
GTwX/ZhgsxiHkZ0gcPM8AyungZPy3GHGbCvgAT7TWxfd0XN19Y0=
=H3Ge
-----END PGP SIGNATURE-----
--azLHFNyN32YCQGCU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200417160556.GA44862>