Date: Sat, 4 Jul 2020 22:11:00 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: pkg@freebsd.org, dev@hardenedbsd.org Subject: Re: Filesystem extended attributes support Message-ID: <20200704201100.lkcde42gtlgspwpr@ivaldir.net> In-Reply-To: <20200704141345.xwdf2ckxak2hfpkh@mutt-hbsd> References: <20200704141345.xwdf2ckxak2hfpkh@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
--ythx3b2ijyq52wix Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 04, 2020 at 10:13:45AM -0400, Shawn Webb wrote: > Hey FreeBSD pkg(8) developers, >=20 > Attached is a patch that implements filesystem extended attributes > support. Only the system namespace is supported. In case the patch > gets scrubbed from this email, I've posted it here: > https://gist.github.com/d0b4653bc5942dbcdcd1db877d37c2dc >=20 > Anyone who wants to write unit tests is welcomed to do so. >=20 > This patch to pkg does depend on a separate patch to libarchive: > https://github.com/libarchive/libarchive/pull/1409 >=20 > HardenedBSD has a separate patch to tmpfs that enables incredibly > basic extended attribute support. The tmpfs patch is only needed for > those who use tmpfs with poudriere. >=20 > And finally, another patch to the jails subsystem that allows a > privileged user within a jail to set system namespace filesystem > extended attributes (disabled by default) is needed for poudriere > users. >=20 > The patch to tmpfs and jails is not included here as they are > tangential. Thank you for the patch at quick glance it looks fine to me. I would have obviously to wait for libarchive to merge the patch first to be able to tes= t it and do a proper review at the time. Don't hesitate to ping me again if you see no progress with libarchive has merged the said patch. I would have to rework it a bit probably: - Add a configure detection of the fact libarchive does or not have the necessary support - Add regression tests to ensure I don't break this in the future. - Maybe add an option to enable/disable it via pkg.conf (not sure yet about that ;)) Best regards, Bapt --ythx3b2ijyq52wix Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl8A4lQACgkQY4mL3PG3 PlqxSBAAyjWHbnGj8IOp3ygToRxcry3lu7sWAVZDiZCgHtkDxqa4oB8E8HUbOa+V fu1zQEYafII4ovthY60pN2IbYWERiurEFbnrDA4Si3Q8Ewf7VWDPUuEJHf4t55NC QyeyPuqLIB5apvxSSkCeOb6WNmqx2HEi201YfoEmvuIu/fykHF2Ch638fUy1xWbC YikkuN5gIinXkh5uJOx7m0WwlJx90/HPV1fkX0ODHSvoCS5T8tRZC4uGx3QVayUP yZ0vcwjCIlcrC15inrMMVA1KFxafORMs7vl9/E6ksmzsYIrUMGbqPpd4DdqI5xhk GfrOHABjswRlAcLsHm3qx8EMYOjOrmALge+DlbSzgMIyprstCCfIh6Qtgik0i6PH C+AYTQFiJp8tbBpgZFabbtrncmQd/Rj0CC3j+ALksXSZW5MtLbcE0+hu9dZeCFTq eHdNywGJ8xkOmIsHJyjz9iLe0Rl3QNwxsSLs/ZwxVBq/MWoIg/qXMgf9RgnyHLvE N/UhLWmjkt0CbEJG65Shn1m21dEXpDj7YTHWN8hciyiHzCMyCkVBZJ+mwPOctvp7 7yGIldgtKSTmBeOBRjprIAcymuG63uwsENTH4rUQNpyOfbTfSPC4h1v75mZq1WVc Rs14zbiGQDcb/8/lgSeo9hT8NFMAlgl3Y4IZKXfiGeXZUtguOZ4= =zRys -----END PGP SIGNATURE----- --ythx3b2ijyq52wix--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200704201100.lkcde42gtlgspwpr>