Date: Sat, 27 Aug 2022 10:20:03 +0200 From: Felix Palmen <zirias@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: New Port: Security/liblurch & Security/Pidgin-lurch Message-ID: <20220827082003.rra2abvwvkbnqdsa@nexus.home.palmen-it.de> In-Reply-To: <CAN2Rk0enAt-0hVj1p%2BafGw5RjAnp4zWcGPGcCEJB5aoyisOP6Q@mail.gmail.com> References: <CAN2Rk0eJU-q%2BBSsS_yvXbkGLYGPn8tnR5kd4sujM=ZNt7Q7sVw@mail.gmail.com> <1062387933.146.1661491191507@localhost> <CAN2Rk0dZcGmqGDS8C6RCv4=dORBUVBeQNU-UNgv9yWSd17cudg@mail.gmail.com> <1126283524.90.1661501545184@localhost> <CAN2Rk0dPVFWBfK0wE-kUQt9eB_5eUOuRpV=vZ1O-q6oQsfjuCg@mail.gmail.com> <CAN2Rk0enAt-0hVj1p%2BafGw5RjAnp4zWcGPGcCEJB5aoyisOP6Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--onmfcaxazz2tojbg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Michael A. Oshin <micadeyeye@gmail.com> [20220827 13:20]: > See the makefile at > https://github.com/micadeyeye/freebsd-ports/blob/master/security/liblurch= /Makefile First of all, this port had *lots* of perfectly avoidable problems, like, nonsensical pkg-plist, many formatting/styling issues, missing dependencies, unnecessary custom rules, ... I strongly recommend you use: * portlint and/or portclippy to statically check your port for following style and best practices. * poudriere testport to test the build of the port, so you find issues like e.g. missing dependencies. Without using these tools, you will have a hard time to come up with a port that's really correct and reliable. --- But then, I had a deeper look. There's actually a "problem" that most likely no beginner would ever be able to solve. This software has two dependencies that are linked upstream as git submodules and optionally built and linked statically. For ports, we can't use such a mechanism (never bundle libraries if there is another way). So, it's necessary to create two other new ports first. Just to give you an idea how it all could be fixed, have a look at the last three commits here: <https://github.com/Zirias/zfbsd-ports/commits/lurch>; The result will build and install correctly. I didn't test whether it actually works. --=20 Felix Palmen <zirias@FreeBSD.org> {private} felix@palmen-it.de -- ports committer (mentee) -- {web} http://palmen-it.de {pgp public key} http://palmen-it.de/pub.txt {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 --onmfcaxazz2tojbg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCYwnTo18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny MRjtAP91CD2mmYkPrP8UzRS3XMhMCj0FQ+QiwwElsAIWOY7g+gD+JmzFZ72qgEEF d7DILF77jfLrhTptVpi5HpAEhX5QVgU= =Ak2q -----END PGP SIGNATURE----- --onmfcaxazz2tojbg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220827082003.rra2abvwvkbnqdsa>