Date: Tue, 25 Nov 2025 08:26:05 +0900 From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> To: Mark Linimon <linimon@portsmon.org> Cc: Warner Losh <imp@bsdimp.com>, Ankush Mondal <ankushmondal1y2t@gmail.com>, hackers@freebsd.org Subject: Re: [PATCH] df: correct BLOCKSIZE handling for -k to use 1K-blocks (290710) Message-ID: <20251125082605.0cb9ab55a2c71a415b575c41@dec.sakura.ne.jp> In-Reply-To: <1789299192.176069.1764023439861@privateemail.com> References: <CAEw80_2bA-NgE_XF0KVr55PSUDGEQTWGE7t9rpxOhykY1MsSvA@mail.gmail.com> <CANCZdfo9XbAKcgtSw953hpwc9jegzPhaVtfk7DtYTKdoHRnkUg@mail.gmail.com> <1789299192.176069.1764023439861@privateemail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 24 Nov 2025 16:30:39 -0600 (CST) Mark Linimon <linimon@portsmon.org> wrote: > > On 11/24/2025 10:03 AM CST Warner Losh <imp@bsdimp.com> wrote: > > Also, we generally don't do code reviews in hackers@. Your best bet is likely a github pull request. I'll keep my eyes open there. > > Then that's even more bad advice in the various Articles/wiki. > > I'll put it on the ever-increasing list ... > > mcl The best way for code review with FreeBSD is Phablicator for me. The accounts are managed by FreeBSD project (or FreeBSD foundation), unlike github. And works fine for me (with some difficulty, though, on opening review with adding files, but it can be overcome). -- Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20251125082605.0cb9ab55a2c71a415b575c41>