Date: Sun, 30 Dec 2001 11:00:16 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Greg Lehey <grog@FreeBSD.org> Cc: Julian Elischer <julian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man3 queue.3 Message-ID: <21051.1009706416@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 30 Dec 2001 09:49:36 %2B1030." <20011230094936.K90696@monorchid.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20011230094936.K90696@monorchid.lemis.com>, Greg Lehey writes: >On Saturday, 29 December 2001 at 8:55:05 +0100, Poul-Henning Kamp wrote: >> In message <200112282200.fBSM0Rw61760@freefall.freebsd.org>, Julian Elischer wr >> ites: >>> julian 2001/12/28 14:00:27 PST >>> >>> Modified files: >>> share/man/man3 queue.3 >>> Log: >>> Document some behaviour I'm depending on. >>> (TAILQ_FOREACH leaves the variable NULL if there were no more to do) >> >> I don't like this. > >Do you have a reason for not liking it? Yes, I don't like statements with weird sideeffects. If julian wants the sideeffect, he should not use a _FOREACH() macro to hide the internals of the loop. _FOREACH() is for the plain & simple traversal of a queue(3) stucture, anything more should explicitly state intent. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21051.1009706416>