Date: Tue, 28 Jul 2009 23:48:58 +0900 From: Alexander Petrovsky <askjuise@gmail.com> To: freebsd-jail@freebsd.org Subject: Re: Jails on ZFS Message-ID: <2ec071a80907280748p336f6356p78d2debcfd8cd18b@mail.gmail.com> In-Reply-To: <9e20d71e0907280716m3968f42pe7aeed2b0286302c@mail.gmail.com> References: <9e20d71e0907280716m3968f42pe7aeed2b0286302c@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>
> Hi,
>
> I'm playing with jails on ZFS and everything is fine, except annoying
> warnings (hopefully just warnings) when doing:
> # /etc/rc.d/jail stop
>
> zfs_umount:971[0]: Force unmount is experimental - report any problems.
> ...
> zfs_umount:971[0]: Force unmount is experimental - report any problems.
>
>
> I found that in rc.d/jail secure_umount() it always do "umount -f "
>
> Maybe it's better first try to unmount without -f and then use force?
>
>
> --- /etc/rc.d/jail 2009-07-22 23:29:29.000000000 +0300
> +++ /etc/rc.d/jail 2009-07-28 14:00:19.998368729 +0300
> @@ -270,7 +270,7 @@
> _dir=3D$1
>
> if is_current_mountpoint ${_dir}; then
> - umount -f ${_dir} >/dev/null 2>&1
> + umount ${_dir} >/dev/null 2>&1 || { sleep 2; umount ${_di=
r}
> >/dev/null 2>&1 || umount -f ${_dir} >/dev/null 2>&1; }
> else
> debug "Nothing mounted on ${_dir} - not unmounting"
> fi
>
Hi, it is may be good idea. But, I can't understand your code, why you do -
umount ${_dir} >/dev/null 2>&1 || { sleep 2; umount ${_dir} >/dev/null 2>&=
1
|| umount -f ${_dir} >/dev/null 2>&1; }
instead
umount ${_dir} >/dev/null 2>&1 || umount -f ${_dir} >/dev/null 2>&1
?
--=20
=D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC =D0=9F=D0=B5=
=D1=82=D1=80=D0=BE=D0=B2=D1=81=D0=BA=D0=B8=D0=B9 =D0=90=D0=BB=D0=B5=D0=BA=
=D1=81=D0=B0=D0=BD=D0=B4=D1=80,
With the best regards Alexander Petrovsky,
ICQ: 350342118
Jabber: juise@jabber.ru
Phone: +7 914 8 820 815
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2ec071a80907280748p336f6356p78d2debcfd8cd18b>