Date: Fri, 23 Apr 2021 12:37:06 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: lev@FreeBSD.org, Chris Rees <crees@bayofrum.net>, Enji Cooper <yaneurabeya@gmail.com>, Adriaan de Groot <adridg@FreeBSD.org> Cc: git@freebsd.org, developers@freebsd.org, Bugmeister <bugmeister@FreeBSD.org> Subject: Re: One surprise in commit messages with git Message-ID: <3096b207-4468-07dd-877d-4e6d365c2e7a@FreeBSD.org> In-Reply-To: <2fe7653d-78e8-2ca2-7508-ca6f27855bfa@FreeBSD.org> References: <2257024.hWAQu6Pgo9@beastie.bionicmutton.org> <AD6AC6E6-DBB8-4868-A5AE-E509283211E0@gmail.com> <F9E1D1FD-1FDC-4ADC-8568-826F33AA564F@bayofrum.net> <2fe7653d-78e8-2ca2-7508-ca6f27855bfa@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23/04/2021 6:27 am, Lev Serebryakov wrote: > On 22.04.2021 23:07, Chris Rees wrote: > >> I would suggest instead that the regex instead be "/ports >> \d\d\d\d\d+/"- this would almost eliminate false positives with >> git > > Maybe, "/\bports \d+\b/" ? > > We (bugmeister) already have this on our radar to address, and we'll come up with a scheme that suits both the historical case and most obvious current case. I believe the majority of historical refs are "<repo> r<integer>". Previous automated svn commit comments were full svn url's I replied to a post on freebsd-current (subject: linking to git revisions in bugzilla) on 12/Apr to this effect, with an 'in the meantime' recommendation, copied below: > We'll (bugmeister) be adding parsing support for it (along with a few > other related auto-linking things) > > I'd encourage people to use "<repo> <short hash>" (repo = > src|doc|ports) where short hash is at least 8 chars in the meantime. > Once parsing is added all previous references will be linked. If anything needs to be tweaked post-fact (updating comments), we'll do that too. Kubilay Bugmeister
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3096b207-4468-07dd-877d-4e6d365c2e7a>