Date: Thu, 20 Aug 2015 13:21:26 -0600 From: Warner Losh <imp@bsdimp.com> To: Dimitry Andric <dim@freebsd.org> Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, current@freebsd.org, imp@freebsd.org Subject: Re: 11-CURRENT build fail with base gcc Message-ID: <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com> In-Reply-To: <BC306807-C29B-4629-AFFA-DA169541818B@FreeBSD.org> References: <CAPQ4ffuNzYQJHxuGKcJ%2BG5b47n-c7DjS6DJX9FrQFu9GGPrpbQ@mail.gmail.com> <B9AED518-76CC-4706-898F-65E72402ABD6@FreeBSD.org> <CAPQ4ffvEsRRhrLHoRhf4D3pUh%2BhnG_DBTHdQbdRNGbpT5Fk7kA@mail.gmail.com> <349EA432-E76D-4D1B-9383-E707967C806D@bsdimp.com> <BC306807-C29B-4629-AFFA-DA169541818B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Aug 20, 2015, at 10:32 AM, Dimitry Andric <dim@freebsd.org> wrote: > > On 20 Aug 2015, at 18:24, Warner Losh <imp@bsdimp.com> wrote: >> >>> On Aug 20, 2015, at 9:38 AM, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote: > ... >> >> I think you are wrong about the cause. -mno-avx is bogusly listed unconditionally >> in efi/Makefile.inc. I’m working on a patch now… > > Ah, this should be replaced with the recently introduced CFLAGS_NO_SIMD > variable, then? Perhaps. Didn’t know this was a thing. That could use useful many places, though there were two clang specific args I needed to move, not just the one that’s in this flag. Maybe things are over-specified? Not sure I like bsd.cpu.mk growing more name-space pollution, especially stuff that isn’t documented somewhere (bsd.cpu.mk is included from sys.mk, which is automaticallyed globally included). All these hacks being stashed hither and yon are starting to get very hard to keep straight for someone who looks at this code every day, let alone somebody who invested CFLAGS_NO_SIMD independently for their code and finds that breaks in an upgrade... Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJV1ii2AAoJEGwc0Sh9sBEAJ/sQAO1omgtIYdSVLJPvhJzGKFGS uNSceBp4Vu89pe2LWuWqA069zwp9tNa9IvQ+YaqXV/+v/YydJxioCfxfvhrjMXLa uoZbiNYzN6qeIlL5J3yYQu/KDkREH1clWm8UhHfMA2PNuKC02ZPQBrWUXqoAS+bi V5MiDVUAf+vI1EYxTLYKeBjohFTYchxlbn5t40UpIXF2ayG/UX9SnyXzepQPac4W 2QpDTHoMxLRlD7pzBhinlHnyZkMV52TwWfkzis6xXM2KEzxEK4cngXWcdVzsS4Yg JCfT3fhOwCaQq1b3gU/orpYHV0QSW8KlIAFskxPUFUUqOT8+JipoGPciHg1ohi29 /c52/QuvCsW0Uw2jW2hYck4YS6OQmgdolN5+68l5x3Pbm+sVUFC4NapRY8nv2fvj m/OLKGGA1GsGWqXHmD6IUJjbE8IYLKBRukAB0F8OneGm2EG8Lm2W96b47YjQRUTG nlJO6GWutJGatJ7rZ84DhOQGKQPfkmT071V7wMZFNeKvWsvPwu5cb/IR3Er96nur 6NCVNSADDNxWjfCqcW8iD/ZIG2GpBwNDl88On7ISxPd7ICw0q6qW8Pr0slc3UpZS mmgdASAKU4FLf0VqEwhlYPcJXsWedpPrhmG2QDX0fg4F6hBSJfyQ/wQ1j8ZdjqtS b+kGwAczVrx7j9ukv13t =5O6R -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30F511DD-2C7C-4252-8870-AC15B36FF36A>