Date: Mon, 25 Feb 2008 08:38:19 -0800 (PST) From: Amatus <c11h15no2@yahoo.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: freebsd-gnome@freebsd.org Subject: Re: Question about updating guile to 1.8 Message-ID: <323881.3492.qm@web30004.mail.mud.yahoo.com> In-Reply-To: <1203916812.38477.2.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > On Sun, 2008-02-24 at 18:07 -0800, Amatus wrote: > > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > > > > > > > On Sun, 2008-02-24 at 14:24 -0800, Amatus wrote: > > > > Hi guys, > > > > I'm working on updating lang/guile to 1.8. > > > > > > Excellent. > > > > > > > I've basically got that > > > > working but there are several other ports that refer to > > > > ${LOCALBASE}/share/guile/1.6 that will need to be fixed. These > are: > > > > security/lsh > > > > lang/slib-guile > > > > finance/gnucash > > > > I've just started doing port development so I'd like to ask > what is > > > the > > > > correct way to fix these ports. What do you guys think of the > > > attached > > > > patch for lang/slib-guile? > > > > > > This patch is okay. But note that GUILE_VERSION is not expanded > > > until > > > it is used in sh. That is, GUILE_VERSION does NOT equal "1.8". > You > > > will not be able to make it equal "1.8" until it is interpreted > by > > > sh. > > > The way you're using it here is fine, though. > > > > > > As for the command itself, it should probably be: > > > > > > `${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2 > -d > > > .` > > > > > > Are you in a position to be run-time testing these ports with the > new > > > guile? Once you're done with your work, do you want to be the > guile > > > maintainer? > > > > > > Joe > > > > I realize it's not expanded immediately. I know in GNU make there > is > > the $(shell) syntax for doing that but I didn't find a way to do > that > > in BSD make. Do you know the Right Way? > > The way you're doing it is probably best. The way you submitted in > the > PR, while it may look correct, will most likely break INDEX when > guile > is not installed. Try it. Uninstall guile, then cd to lang/slib, > and > run "make describe". Use of != is discouraged for commands which are > not in the base system. > > Joe I uninstalled guile and make describe worked fine with some noise on stderr. I'm running into more problems with gnucash and lsh using RUN_DEPENDS. I need to .include <bsd.port.pre.mk> before the != but if I move it up too high in the file (before RUN_DEPENDS) then make breaks. Would it be ok to just edit the dependency to be "slib-guile>=3a4:${PORTSDIR}/lang/slib-guile" instead of "${LOCALBASE}/share/guile/1.6/slibcat:${PORTSDIR}/lang/slib-guile"? Thanks. ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?323881.3492.qm>