Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Sep 2003 09:47:07 +0300 (EEST)
From:      "Jukka A. Ukkonen" <jau@mawit.com>
To:        freebsd-questions@FreeBSD.org
Subject:   [Fwd: Support for default passive ftp mode in fetch]
Message-ID:  <3326.62.78.135.6.1064731627.squirrel@office.mawit.com>

next in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]

To be really efficient I tried to send the following message to "core-team"
which obviously failed. So, here is the same minor change proposal sent
to freebsd-questions. I hope some of the people who can take appropriate
action are on this list.

-- 
        Cheers,
                // jau
.---  ..-  -.-  -.-  .-    .-  .-.-.-    ..-  -.-  -.-  ---  -.  .  -.
  /    Jukka A. Ukkonen,                            Mawit Ltd, Finland
 /__   M.Sc. (sw-eng & cs)                    (Phone) +358-500-606-671
   /   Internet: Jukka.Ukkonen(a)Mawit.Com      (Home) +358-9-6215-280
  /    Internet: ukkonen(a)nic.funet.fi
 v     Internet: jau(a)iki.fi

+ + + + My opinions are mine and mine alone, not my employers. + + + +


-------- Original Message --------
Subject: Support for default passive ftp mode in fetch
From: "Jukka A. Ukkonen" <jau@mawit.com>
Date: Sun, September 28, 2003 0:57
To: <FreeBSD-gnats-submit@freebsd.org>, <core-team@freebsd.org>

Hi!

The fact that fetch which is used by ports make when a distfile is not
already around has had no means to make it use passive ftp mode
by default has often caused me problems.
So, I finally decided to add this feature analogous to the plain ftp client
which uses the environment variable FTP_PASSIVE_MODE. Now my
modified fetch also obeys this environment variable. Find the diffs
attached. I hope everybody agrees this change would be a useful addition to
the base distribution.

-- 
        Cheers,
                // jau
..---  ..-  -.-  -.-  .-    .-  .-.-.-    ..-  -.-  -.-  ---  -.  .  -.
  /    Jukka A. Ukkonen,                            Mawit Ltd, Finland
 /__   M.Sc. (sw-eng & cs)                    (Phone) +358-500-606-671
   /   Internet: Jukka.Ukkonen(a)Mawit.Com      (Home) +358-9-6215-280
  /    Internet: ukkonen(a)nic.funet.fi
 v     Internet: jau(a)iki.fi

+ + + + My opinions are mine and mine alone, not my employers. + + + +



[-- Attachment #2 --]
--- fetch.c.orig	Fri Sep 26 23:07:02 2003
+++ fetch.c	Sun Sep 28 00:32:22 2003
@@ -703,6 +703,15 @@
 	char *end, *q;
 	int c, e, r;
 
+	p = getenv ("FTP_PASSIVE_MODE");
+
+	if (! p || ! strcasecmp (p, "NO")) {
+		p_flag = 0;
+	}
+	else {
+		p_flag = 1;
+	}
+
 	while ((c = getopt(argc, argv,
 	    "146AaB:bc:dFf:Hh:lMmN:nPpo:qRrS:sT:tUvw:")) != -1)
 		switch (c) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3326.62.78.135.6.1064731627.squirrel>