Date: Sun, 19 Oct 2008 09:52:20 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Christian Kandeler <christian.kandeler@hob.de> Cc: freebsd-ia64@freebsd.org Subject: Re: Question about ia64_ap_startup() Message-ID: <35C58F22-E133-49AB-923E-AE858802D389@mac.com> In-Reply-To: <200810171319.38605.christian.kandeler@hob.de> References: <200810171319.38605.christian.kandeler@hob.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 17, 2008, at 4:19 AM, Christian Kandeler wrote: > Hello, > > I've been looking at the implementation of ia64_ap_startup() and it > seems to me that the "ap_awake++" statement has a rather obvious race > condition. Shouldn't one of the atomic macros be used here instead? > Or am I missing something? No, you're not missing anything. It should use an atomic operation. -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35C58F22-E133-49AB-923E-AE858802D389>