Date: Wed, 16 Jun 2010 02:38:29 -0700 From: Ade Lovett <ade@FreeBSD.org> To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> Cc: freebsd-ports@FreeBSD.org Subject: Re: RFC: Mk/bsd.jpeg.mk to automagically handle jpeg dependency Message-ID: <372D79A4-91FB-43F2-9B43-A8FCC80FC004@FreeBSD.org> In-Reply-To: <20100616010957.85686.qmail@exxodus.fedaykin.here> References: <20100616010957.85686.qmail@exxodus.fedaykin.here>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 15, 2010, at 18:09 , Mario Sergio Fujikawa Ferreira wrote: > Hi, >=20 > Ever since the addition of graphics/libjpeg-turbo, I had > been wondering how one could possibly build the whole ports tree > with it instead of graphics/jpeg. I wanted the choice. >=20 > Therefore, I wrote the attached bsd.jpeg.mk as a suggestion. I have other concerns, but the fundamental one is bsd.jpeg.mk is way too = specific, and could easily lead to bsd.tiff.mk, bsd.gd.mk, etc.. etc.. You might want to consider abstracting it out a little further (compare = with bsd.database.mk) to, say, bsd.graphics.mk It might then be possible to do weird and wonderful things like: USE_GRAPHICS=3D jpeg-turbo openexr gd tiff in ports Makefiles, and have them do the right thing, or at least offer = up include and library paths, along with relevant *_DEPENDS additions. It's a little more work in the short term, but there's plenty of = existing Mk/* files to use as reference for parsing a possible = USE_GRAPHICS stanza, and it is much more extensible. -aDe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?372D79A4-91FB-43F2-9B43-A8FCC80FC004>