Date: Fri, 22 Jul 2016 10:53:59 +0200 From: Jan Beich <jbeich@vfemail.net> To: Russell Haley <russ.haley@gmail.com> Cc: olli hauer <ohauer@gmx.de>, freebsd-ports@freebsd.org Subject: Re: Passing target to source Makefile Message-ID: <37n2-9hp4-wny@vfemail.net> In-Reply-To: <CABx9NuQyh8iirhiPQHqZYAmTU5E%2BdEp6_kN2U0WKOU9F_Tuuqw@mail.gmail.com> (Russell Haley's message of "Thu, 21 Jul 2016 13:25:17 -0600") References: <CABx9NuQWqC2%2Bx82rT2zUa=qKiaC-EjUtfY7tess5NVpn8n-cgg@mail.gmail.com> <3b9c2f92-ef57-3e06-c110-8148dce16ba5@gmx.de> <CABx9NuQyh8iirhiPQHqZYAmTU5E%2BdEp6_kN2U0WKOU9F_Tuuqw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Russell Haley <russ.haley@gmail.com> writes: > 1) It does not use the recommended "freebsd" target. While the port > overlays many of the same options, the system doesn't seem to respect > the targets and also performs the installation without specifically > calling the "install" target. Try adding ALL_TARGET=freebsd. INSTALL_TARGET already defaults to "install" and then the port appends extra steps via post-install. $ make -V ALL_TARGET -C lang/lua53 all > The current supported version of Lua is 5.3. While I can see the need > to install past versions using explicit naming, it is my opinion that > the current version should be installed as Lua, not luaXX. Say, a port looks for Lua 5.1 headers. If Lua 5.3 is installed without suffix the port may find wrong headers first. And fixing include order isn't always trivial with complex build systems. But -isystem as used by USES=localbase partially alleviates that. > 4) The current Makefile applies -fPIC to some of the platforms, but > not armv6. https://svnweb.freebsd.org/changeset/ports/409263 > - Update to the latest Lua revision Do you mean Mk/bsd.default-versions.mk? lang/lua53 is already at 5.3.3. > - Use clang and bmake instead of forcing gcc/gmake. bmake isn't available on FreeBSD 9.3-RELEASE which isn't going to be EOL'd until the next year. If you mean devel/bmake then I don't see the benefit compared to devel/gmake - both are extra dependencies. Also see https://svnweb.freebsd.org/changeset/ports/285048 > Please also note that I have made an upstream request to the Lua > community to consider applying a patch to the freebsd target in their > source/Makefile. The patch can be found here: > http://pastebin.com/cUCtWb1w. I don't expect this to happen quickly > however. "freebsd" target is only slightly different from "linux" one. There's no support to build shared library upstream, so -fPIC isn't required unless you need to link liblua.a into another shared library. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJXkd8nXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bLAkH/RyLNqhfqHCu+ctThTsKUdZP cvYp3kqhojYWPPuIfwES+jDQl/NVs6TQ1JUhq3w3F2p/wI33Y6lHG+IOOfMYOt6l 1u3k9le1T9PaEUx04/+zDLaUtlK3f6VOxE6p0OLg66kxYDe+EovoXsqVQNJC+tof jgITQE2qqzJValxEIrjN3H4dJvFLanFDBKV7LfffesBQY4iXvTujMo/q4yEfz9rj oQy9slF4L9g5F5mrBfc//CB2BaIF2SknCJmiASO7eREaIFC8gSbXwNViIb5S11YT pKyU/jrbTkowoyXibsmdyqGJTZFvhN5lp7ANEHn5QpB04MtwcddTScB1m1fEYGQ= =5ZAB -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37n2-9hp4-wny>