Date: Thu, 02 Dec 1999 10:07:24 +0100 From: Marcel Moolenaar <marcel@scc.nl> To: Alfred Perlstein <bright@wintelcom.net> Cc: Reinier Bezuidenhout <rbezuide@oskar.dev.nanoteq.co.za>, wilko@yedi.iaf.nl, groudier@club-internet.fr, FreeBSD-hackers@FreeBSD.ORG Subject: Re: Linux ioctl not implemented error Message-ID: <384636CC.A184B6D0@scc.nl> References: <Pine.BSF.4.21.9912020043190.4557-100000@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote:
>
> > + if (!error) {
> > + lvol = *lvolp;
> > + lvol.channel0 = bsd_vol.vol[0];
> > + lvol.channel1 = bsd_vol.vol[1];
> > + lvol.channel2 = bsd_vol.vol[2];
> > + lvol.channel3 = bsd_vol.vol[3];
>
> FYI the kernel structures are completely identical, you don't really
> gain anything by doing this convertion. Should this be put in for
> clarity? I'm not sure.
No. When it's there, you automaticly assume it's there for a reason.
Since the structures are identical, there's no reason for the code to be
there. Very confusing :-)
--
Marcel Moolenaar mailto:marcel@scc.nl
SCC Internetworking & Databases http://www.scc.nl/
The FreeBSD project mailto:marcel@FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?384636CC.A184B6D0>