Date: Fri, 23 Mar 2001 15:02:13 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Peter Pentchev <roam@orbitel.bg> Cc: Ville Eerola <ve@sci.fi>, Doug Barton <DougB@DougBarton.net>, ports@FreeBSD.ORG Subject: Re: fetchmail port broken on releng_3 Message-ID: <3ABB4955.8276513B@FreeBSD.org> References: <3ABA701A.726DFA85@yahoo-inc.com> <3ABAFEC8.62BC5188@DougBarton.net> <20010323131917.B17216@ringworld.oblivion.bg> <3ABB3D58.5979B11C@FreeBSD.org> <20010323144918.I17216@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Pentchev wrote:
> On Fri, Mar 23, 2001 at 02:11:04PM +0200, Maxim Sobolev wrote:
> > Peter Pentchev wrote:
> >
> > > How about the following patch instead? It incorporates your fix
> > > (sorry about that, when I submitted patches adding Kerberos and SSL
> > > support, I had already upgraded to 4.x; never had a chance to test
> > > anything on RELENG_3), and adds the correct fix to the NLS build -
> > > I've already submitted the aclocal.m4 fix to the fetchmail-friends
> > > list. It seems that aclocal.m4 was NOT generated from the latest
> > > version of configure.in and friends :( The patch-aclocal.m4 resulted
> > > directly from an aclocal invocation :(
> > >
> > > I could commit this ASAP, pending maintainer approval.
> > >
> [snip]
> >
> > Have you tested build on a system without auto{make,conf} installed?
>
> Hrm. OK, so ESR has slipped up again - configure checks correctly
> for a missing autoconf/automake/whatever, but fetchmail does not provide
> a 'missing' script. Updated patch follows, problem reported to ESR
> and fetchmail-friends, hopefully to be fixed in the next release.
>
> Actually, there are two issues here - the libintl thing is only added
> by the aclocal.m4, which is only picked up by an aclocal.. ARGH!
> Alright, so we'll have to keep the -lintl addition to LDFLAGS, until
> the configure script is regenerated with the correct aclocal.m4 :(
>
> I think those two fixes are the correct way of fixing things - the 'missing'
> script is part of the GNU configure ideology, and configure scripts were
> designed to work properly without autoconf installed on the system.
> It's just the fact that ESR has not provided such a script that breaks
> the fetchmail build when no autoconf is present. And the other issue..
> well, if there is autoconf on the system, aclocal.m4 shall pick up
> -lintl anyway, and there's no harm in having it twice. If there isn't,
> then yes, your addition to LDFLAGS was needed. Sorry for not recognizing
> it from the start :(
>
>
> Index: ports/mail/fetchmail/files/missing
> ===================================================================
> RCS file: missing
> diff -N missing
> --- /dev/null Fri Mar 23 04:45:23 2001
> +++ ports/mail/fetchmail/files/missing Fri Mar 23 04:47:48 2001
Peter, I respect your desire to fix things `properly', but really do not see a sufficient reason
to pollute our repo with missing `missing' script. Please just use my 4-line patch-configure to
get rid of it. This script is useless anyway.
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ABB4955.8276513B>