Date: Sat, 09 Jun 2001 16:25:19 -0700 From: Doug Barton <DougB@DougBarton.net> To: John Polstra <jdp@polstra.com> Cc: ports@FreeBSD.ORG, mjacob@feral.com Subject: Re: not sure if this is a good patch or not... (fwd) Message-ID: <3B22B05F.16227A31@DougBarton.net> References: <20010609132536.R4572-100000@wonky.feral.com> <200106092142.f59LgcL55293@vashon.polstra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
It's much better to use the value of ${PTHREAD_LIBS} somehow, possibly in
CONFIGURE_ENV if the port will support it. PTHREAD_LIBS does the right
thing on both -current and RELENG_4.
Doug
John Polstra wrote:
>
> In article <20010609132536.R4572-100000@wonky.feral.com>,
> Matthew Jacob <mjacob@feral.com> wrote:
>
> > Needed to compile under 4.3:
> >
> > Index: files/patch-Makefile.Linux.Mesa
> > ===================================================================
> > RCS file: /home/ncvs/ports/games/tank/files/patch-Makefile.Linux.Mesa,v
> > retrieving revision 1.1
> > diff -u -r1.1 patch-Makefile.Linux.Mesa
> > --- files/patch-Makefile.Linux.Mesa 2001/03/14 12:20:49 1.1
> > +++ files/patch-Makefile.Linux.Mesa 2001/06/09 20:16:59
> > @@ -38,7 +38,7 @@
> > $(CC) -o $(EXECNAME) $(Obj) $(LDFLAGS) \
> > - -lMesaaux -lMesatk -lMesaGLU -lMesaGL \
> > - -lXext -lX11 -lm
> > -+ -laux -lGLU -lGL -lXext -lX11 -lm
> > ++ -laux -lGLU -lGL -lXext -lX11 -lm -lc_r
> > @echo "****** Done ******"
> >
> > linux: $(Obj)
> >
>
> Not a good patch. Add "-pthread" to LDFLAGS instead. The patch as
> it stands will link in both -lc_r and -lc, but the two cannot coexist
> safely.
>
> John
> --
> John Polstra jdp@polstra.com
> John D. Polstra & Co., Inc. Seattle, Washington USA
> "Disappointment is a good sign of basic intelligence." -- Chögyam Trungpa
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message
--
If you're never wrong, you're not trying hard enough.
Do YOU Yahoo!?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B22B05F.16227A31>