Date: Fri, 22 Feb 2002 21:35:46 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Will Andrews <will@csociety.org> Cc: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>, portmgr@FreeBSD.org, FreeBSD-ports@FreeBSD.org Subject: Re: bsd.port.mk MASTER_SITES_NN misbehavior (was ghostscript-afpt and MASTER_SITES_NN patch) Message-ID: <3C769D92.7C1C441F@FreeBSD.org> References: <20020221221039.19324.qmail@exxodus.fedaykin.here> <3C764483.F20F486C@FreeBSD.org> <20020222144830.GS82673@squall.waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Will Andrews wrote: > > On Fri, Feb 22, 2002 at 03:15:47PM +0200, Maxim Sobolev wrote: > > > The MASTER_FILTER_PERL idea was discussed with Anton Berezin > > > (project tobez :). After constructing any variables, we use it to > > > remove ANY repeated instances since repetition means bogus instance. > > > It is a neat thing, not only it "hides" the MASTER_SITES_NN problem > > > but also add a level of protection against poorly written MASTER_SITES. > > > Let me know what do you think. > > > > I object. This is a bad practice to use a workaroung to fix misdesign > > instead of fixing the real source of the problem. Please fix > > MASTER_SITES_NN properly. > > What exactly is a "bad practice"? Bad practice is using a workaround to fix the problem instead of fixing underlying algorithm. > What's "misdesigned"? Misdesign here is that MASTER_SITES_NN lists some sites several times. > What's > the "real source of the problem"? Donno, because I'm not the author of the feature in question. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C769D92.7C1C441F>