Date: Thu, 18 Apr 2002 18:59:29 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: obrien@FreeBSD.ORG Cc: ports@FreeBSD.ORG Subject: Re: Tools/scripts/patchtool.py Message-ID: <3CBEED61.AFF1C3BC@FreeBSD.org> References: <20020418080638.A86691@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > > Are you the owner of this file such that others cannot commit to it? > I want to make this commit. My justification is that '/' in path names > of the file being patch are turned into _four_ characters by shell's > autocompletion -- "\:\:" which makes patches very long. > > I also do not understand why every patch in ports/java/jdk13/files is > named "patch-.." by your script (ie, why the ..). But maybe we can work > on that next. Making a few changes will make living with these silly > paths easier as at least they will fit on a single 80 character line in > an ls listing. > > Index: patchtool.py > =================================================================== > RCS file: /home/ncvs/ports/Tools/scripts/patchtool.py,v > retrieving revision 1.9 > diff -u -r1.9 patchtool.py > --- patchtool.py 17 Apr 2002 10:58:57 -0000 1.9 > +++ patchtool.py 18 Apr 2002 15:02:16 -0000 > @@ -50,8 +50,8 @@ > DEV_NULL = '/dev/null' > ETC_MAKE_CONF = '/etc/make.conf' > > - SLASH_REPL_SYMBOL = '::' # The sysmbol to replace '/' when auto-generating > - # patchnames > + SLASH_REPL_SYMBOL = '_' # The sysmbol to replace '/' when > + # auto-generating patchnames Approved, but please leave the comment alone - the file assumes 4-spaces tabs. Thanks! -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CBEED61.AFF1C3BC>