Date: Sun, 12 Jan 2003 01:10:30 -0700 From: Scott Long <scott_long@btc.adaptec.com> To: Alfred Perlstein <bright@mu.org> Cc: Jake Burkholder <jake@locore.ca>, Matthew Dillon <dillon@apollo.backplane.com>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <3E2122F6.70400@btc.adaptec.com> In-Reply-To: <200301120137.h0C1bD0E098037@repoman.freebsd.org> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112014644.F212@locore.ca> <20030112075042.GE33821@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote: > * Jake Burkholder [030111 22:46] wrote: > > >Its unnecessary code churn. I wouldn't be surprised if struct file was > >used all the place in 3rd party modules, especially MAC modules. Now > >they either need an ugly compat define or ugly idfefs. Some of your > commits > >were to code that's externally maintained. We've broken > compatibility with > >external code before for compelling reasons. This is not a > compelling reason. > > > >You obviously don't think this is important, I do. If no one else > cares about > >this I'll shut up now. > > > I prefer Jake's idea of just removing the casts where they are unneeded. > > This adds unneeded complexity and renaming that we don't need. > > It also reduces diffs to what will be 5-stable. > With an re@ hat on, I agree with Alfred. When RELENG_5_0 was branched we asked that gratuitous changes and API, ABI, etc changes be kept to a minimum and that re@ be consulted before doing them. Cleaning up the code is fine, changing the names and types of structure members in the API goes against the spirit of what was requested. Please revert your changes to sys/sys/file.h. Scott To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E2122F6.70400>