Date: Tue, 16 Feb 2010 20:58:06 +0100 From: Attilio Rao <attilio@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: FreeBSD Arch <arch@freebsd.org>, Ed Maste <emaste@sandvine.com> Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch Message-ID: <3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1@mail.gmail.com> In-Reply-To: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/2/16 Kostik Belousov <kostikbel@gmail.com>: > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. > > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) > operation now, without a review, and post a diff that should be applied > to x86/ directory, as well as to build glue. I'm not sure what you mean here. I also thought svn mv was keeping the file history (the old cvsup repocopy) and handling directly the svn del. > The small proposition I have is to #define read_eflags() read_rflags() > for amd64. I thought about having an unified read_flags() but to do that pass later. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1>