Date: Wed, 21 Apr 2021 15:00:21 -0700 From: Mark Millard <marklmi@yahoo.com> To: Gleb Popov <arrowd@freebsd.org> Cc: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: Re: A bug with getsockopt(SOL_LOCAL, LOCAL_PEERCRED) ? Message-ID: <40116716-D8D9-438D-A168-B26A112D199E@yahoo.com> In-Reply-To: <CALH631mi0xOQGjd6F3Beu_BQdqAx8RYCrbkUi524F8S4rwo1aA@mail.gmail.com> References: <CALH631kLCApctk4iQJj6br0Pzeb6qsh9g3jz_SA8hH91ftQGDQ@mail.gmail.com> <YHiQ6qEjS2w8uYpS@kib.kiev.ua> <CALH631=3hqvfraume467OM%2BqGqp854sGJFfhO8b61mF%2BkbsJ2Q@mail.gmail.com> <E6626DFC-2014-412C-AEA2-ECE57835B058@yahoo.com> <CALH631mi0xOQGjd6F3Beu_BQdqAx8RYCrbkUi524F8S4rwo1aA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-Apr-21, at 11:27, Gleb Popov <arrowd at freebsd.org> wrote: >> On Thu, Apr 15, 2021 at 10:58 PM Mark Millard <marklmi@yahoo.com> = wrote: >> The way I read the above quote and your code and >> related documentation: s2 after the accept4 assignment >> is specific to the client's specific connect and >> will give access to the connected user's credentials >> --but s is not specific to the specific connect in >> question (after that assignment or later) and would >> not give the information that you indicate that you >> want: you need a connection-specific identifier. >>=20 >> In other words, it looks to me like what you quoted >> agrees with what Konstantin reported. >>=20 >> . . . >=20 >=20 > This makes sense, thanks. >=20 > However, this code works on Linux and seems to return credentials of = the user that started the process. I actually stumbled upon this when = porting this code: = https://github.com/CollaboraOnline/online/blob/master/net/Socket.cpp#L805 >=20 > Would it make sense if FreeBSD followed Linux semantics in this case? = If not, what are my options for porting the software? =46rom what I can tell . . . FreeBSD defines LOCAL_PEERCRED and what goes with its use, not linux. Linux defines SO_PEERCRED and what goes with its use, not FreeBSD. If I understand right, your code is incompatible with the referenced CollaboraOnline code from just after the #else (so __FreeBSD__ case, not the linux case): getsockopt(getFD(), 0, LOCAL_PEERCRED, &creds, &credSize) vs. your: getsockopt(s, SOL_LOCAL, LOCAL_PEERCRED, &creds, &credSize) Note the 0 vs. the SOL_LOCAL. Your code is a mix of Linux and FreeBSD code when it should not be. See also the following that involved replacing a SOL_LOCAL with a 0 for getsockopt used with LOCAL_PEERCRED: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234722 =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40116716-D8D9-438D-A168-B26A112D199E>