Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jan 2004 01:42:12 +0100
From:      Oliver Eikemeier <eikemeier@fillmore-labs.com>
To:        Sergei Kolobov <sergei@kolobov.com>
Cc:        freebsd-ports@FreeBSD.org
Subject:   Re: ports/49955: [PATCH] bsd.port.mk: add target to automatically install port documentation
Message-ID:  <40170564.4050107@fillmore-labs.com>
In-Reply-To: <20040127160204.GA704@chetwood.ru>
References:  <1075068827.93327.13.camel@shumai.marcuscom.com> <20040127160204.GA704@chetwood.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
Sergei Kolobov wrote:

> To summarize:
> 
> PORTDOCS dramatically reduces pkg-plist size in case
> there are a lot of files and/or subdirs under DOCSDIR.
> For example, PORTDOCS=*.
> 
> My patch (let's call it DOCS) is for far more common scenario
> (in my experience, at least) - there are just a few docs files
> which could (and should) be listed explicitly.
> 
> I just had an idea how this two approaches be combined into
> single framework:
> 
> Ports that have few doc files get this:
> 
> DOCS=		file1 file2 subdir/file3

this doesn't save you much compared with

	@cd ${WRKSRC}/doc && ${INSTALL_DATA} file1 file2 subdir/file3 ${DOCSDIR}

it yould be interesting when this macro could copy hierarchies. Anyway, do
you have a sample port the would benefit from a DOCS macro? I named to Java
ports a examples (using javadoc, i.e. junit, java3d, forte, whatever) for the
PORTDOCS macro, because

- they have dynamically generated documentation, changing often
- have a large, deep documentation tree
- install the documentation themselves
- don't always honour NOPORTDOCS

so a good candidate for your patch would be a port with a large, deep documentation
tree that isn't installed (bouncycastle). Or is your point that most people are too
lazy to write

PORTDOCS=	NEWS Changelog

.ifndef NOPORTDOCS
	@${MKDIR} ${DOCSDIR}
	@cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
.endif

but would use

DOCSSRC=	NEWS Changelog

instead?

And please avoid INSTALL_DOCS, it's too similar to INSTALL_MAN.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40170564.4050107>