Date: Wed, 02 Jun 2004 15:40:06 +0200 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: Kris Kennaway <kris@obsecurity.org> Cc: ports@FreeBSD.org Subject: Re: INDEX patch Message-ID: <40BDD8B6.80103@fillmore-labs.com> In-Reply-To: <20040602132149.GA55452@xor.obsecurity.org> References: <20040602121648.GA51625@xor.obsecurity.org> <40BDCC4B.9000708@fillmore-labs.com> <20040602132149.GA55452@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote:
> On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote:
>
>>Kris Kennaway wrote:
>>
>>
>>>A previous commit to bsd.port.mk broke the reporting of missing
>>>dependencies from 'make index'. This patch restores it (and makes
>>>these errors fatal). I plan to commit it soon.
>>>
>>>Kris
>>
>>May I suggest the following patch:
>>
>>- check for existence of perl (cf. my RFC on ports-developers)
>>- enables the use of `env PATH= /usr/bin/make describe' (nice for testing)
>
> Nice idea, but running this test 11000 times is suboptimal :-)
Because test is a sh-builtin, and the file system should cache this information
I don't expect to see any difference. Especially since spawning perl 11000 times
is more than suboptimal ;) You didn't mean this serious, did you?
> Also, it recommends the wrong perl port.
Just replace it with "lang/${PERL_PORT}".
-Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40BDD8B6.80103>