Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 09 Aug 2005 11:16:53 +0400
From:      Sergey Matveychuk <sem@FreeBSD.org>
To:        Vsevolod Stakhov <vsevolod@freebsd.org>
Cc:        freebsd-ports@freebsd.org
Subject:   Re: bsd.database.mk suggestion
Message-ID:  <42F85865.3010406@FreeBSD.org>
In-Reply-To: <20050808113340.GD71954@spray.anyhost.ru>
References:  <20050808113340.GD71954@spray.anyhost.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
Vsevolod Stakhov wrote:
> Hi,
> 
> I think bsd.database.mk is now more or less ready. But I want
> to listen your comments about it. Now I've moved all mysql/pgsql 
> related stuff from bsd.port.mk to bsd.database.mk and added
> bdb handling and sqlite dependency.

A symantics for variables is differ. I'm not sure it's a good thing.
E.g.
USE_MYSQL - yes|undefined
WANT_MYSQL_VER - mysql version a maintainer wants
WITH_MYSQL_VER - mysql version an user wants
The same for PostgreSQL.

But you use USE_DBD_VER= yes|version.
USE_DBD_VER=yes is weird.

<IMHO>
I dislike _VER suffix for USE_FOO.
Well, I dislike WANT_FOO too. I think it's a surcharge.

I like this scheme:
USE_SOMEDB=  yes|version
It's just like USE_GCC do.
</IMHO>

-- 
Sem.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42F85865.3010406>