Date: Fri, 16 Dec 2005 00:17:14 +0100 From: =?UTF-8?B?VsOhY2xhdiBIYWlzbWFu?= <V.Haisman@sh.cvut.cz> To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> Cc: freebsd-hackers@freebsd.org, phk@freebsd.org Subject: Re: [CALL FOR TESTERS] New system call: abort2() Message-ID: <43A1F97A.3060102@sh.cvut.cz> In-Reply-To: <20051215223745.GA37768@FreeBSD.czest.pl> References: <20051215223745.GA37768@FreeBSD.czest.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigE53270F597569BF16AC1E89D
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Wojciech A. Koszek wrote:
[...]
> Comments are welcome!
As for the patch, the use of do {} while(0) instead of goto looks odd to me.
I would like to comment on FreeBSD style(9) a bit. Why does not mention
or even encourage C99 style // comments? They are nice when one wants to
comment out bigger chunks of code with /**/ comment.
On the similar note, the ability to move declarations closer to the
point of use in code is IMO nice feature, too. The style(9) doesn't
mention this either.
Vaclav Haisman
--------------enigE53270F597569BF16AC1E89D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iQEVAwUBQ6H5gm56zbtzMDG0AQLglQf/cbfD2GjmmNzg56Q54jZFdabVXMnAdiYG
Dfu7+bBy9IFdKow1hF08W3sd2TYK5Byfb8PHeTdppUdl9tmKPpg61yduuUEkEJYy
IOnpig5QWkZG3Mq+80BSAlBzfcBqKXmF0wsYKnTyApMTK1ISyHiFDkmNNhKUEPTV
6/xhjeUC0Zfjo8cMLAstmaA5e37OzGYX5wdrayRKTjKmN2OSIl1DuQB2I2WKfNd+
j6nTpP+Gf78petjtMIbdVOwAHz0Z2hrM+V7sxgPoPLgxN1wLTsPZJnTR34PxUS81
IEt0XfHf2FtCmusZH4AqaFqNWWoM1B1L3MrzE65Ezra5iH2nOsJpiw==
=MNXn
-----END PGP SIGNATURE-----
--------------enigE53270F597569BF16AC1E89D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43A1F97A.3060102>