Date: Fri, 13 Jan 2006 23:09:48 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> Cc: ports@freebsd.org, Mike Jakubik <mikej@rogers.com>, FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org> Subject: Re: [PATCH] security/courier-authlib-base: update rc.d script to REQUIRE mysql_client Message-ID: <43C8A3BC.1070108@FreeBSD.org> In-Reply-To: <20060113020125.5c1317a1@it.buh.tecnik93.com> References: <1137031540.61580@it.buh.tecnik93.com> <43C6EAE9.5070901@rogers.com> <20060113020125.5c1317a1@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ion-Mihai Tetcu wrote:
> On Thu, 12 Jan 2006 18:48:57 -0500
> Mike Jakubik <mikej@rogers.com> wrote:
>> I think the real solution would be to generate the required services
>> dynamically based on what the port is compiled with. This obviously
>> means some more work, but i think a lot of port maintainers will have
>> to go through this, to properly utilize RCng. Examples can be
>> apparently taken from the misc/compat5 port.
>
> Or my mail/dspam-devel.
You definitely have some cool stuff in there! I would like to mention one
little nit, that I was actually reminded of myself recently. When you do
default variable values, it's better to do it like this:
dspam_enable=${dspam_enable-"NO"}
rather than with the colon. That way if the user has done this in
/etc/rc.conf: dspam_enable="" the default will still be no (since -
replaces the value only if it's unset, whereas :- replaces if it is unset OR
null). This isn't too meaningful for things like _enable where either result
would have basically the same effect, but it is meaningful for things like
_flags, where in your script, if the user did dspam_flags="" they would
unexpectedly have nothing replaced with your default.
hth,
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43C8A3BC.1070108>