Date: Thu, 10 Aug 2006 01:29:13 +0200 From: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@FreeBSD.org> To: John E Hein <jhein@timing.com> Cc: ports@FreeBSD.org Subject: Re: support for DESTDIR: security/openssh-portable Message-ID: <44DA6FC9.3040404@FreeBSD.org> In-Reply-To: <17626.25444.563099.956775@gromit.timing.com> References: <17626.25183.846983.515718@gromit.timing.com> <17626.25444.563099.956775@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John E Hein wrote:
> John E Hein wrote at 16:31 -0600 on Aug 9, 2006:
> > Now that ports/Mk does the right thing for DESTDIR (thanks to Gábor),
> > here's a patch that supports DESTDIR properly for
> > security/openssh-portable:
> >
> [snip]
> > @@ -171,29 +171,33 @@ post-extract:
> > post-patch:
> > @${REINPLACE_CMD} -e 's|-ldes|-lcrypto|g' ${WRKSRC}/configure
> >
> > +.if defined(DESTDIR) && !empty(DESTDIR)
> > +CHROOTDESTDIR=${CHROOT} ${DESTDIR}
> > +.endif
> > +
> [snip]
> > .endif
> > - if ! pw groupshow sshd; then pw groupadd sshd -g 22; fi
> > - if ! pw usershow sshd; then pw useradd sshd -g sshd -u 22 \
> > + if ! ${CHROOTDESTDIR} pw groupshow sshd; then ${CHROOTDESTDIR} pw groupadd sshd -g 22; fi
> > + if ! ${CHROOTDESTDIR} pw usershow sshd; then ${CHROOTDESTDIR} pw useradd sshd -g sshd -u 22 \
> > -h - -d ${EMPTYDIR} -s /nonexistent -c "sshd privilege separation"; fi
>
> Gabor, you may want to define CHROOTDESTDIR (or name it whatever you
> want) as a convenience var in bsd.port.mk
>
> I suspect lots of ports will want to use it.
>
Might be good, but personally I think ${CHROOT} ${DESTDIR} is more
trivial (easier to read and understand) and only longer with 4
characters. One might wonder at first look what CHROOTDESTDIR is.
CC'd to ports@ to see what others think.
--
Cheers,
Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44DA6FC9.3040404>