Date: Wed, 17 Nov 2004 06:39:00 -0500 From: Michael Johnson <ahze@ahze.net> To: Jose M Rodriguez <josemi@freebsd.jazztel.es> Cc: freebsd-gnome@freebsd.org Subject: Re: About firefox new layout Message-ID: <4625EB54-388D-11D9-8B95-000A95BB7150@ahze.net> In-Reply-To: <200411171158.11611.freebsd@redesjm.local> References: <200411170947.45235.freebsd@redesjm.local> <66E1C082-387E-11D9-8B95-000A95BB7150@ahze.net> <200411171158.11611.freebsd@redesjm.local>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail-3--22227607
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
On Nov 17, 2004, at 5:58 AM, Jose M Rodriguez wrote:
> El Mi=E9rcoles, 17 de Noviembre de 2004 10:52, Michael Johnson =
escribi=F3:
>> On Nov 17, 2004, at 3:47 AM, Jose M Rodriguez wrote:
>>> El Mi=E9rcoles, 17 de Noviembre de 2004 05:52, Joe Marcus Clarke
>>>
>>> escribi=F3:
>>>> Jose M Rodriguez wrote:
>>
>> ---- snip ----
>> [...]
>>>> | This must be not only easier, but also safer.
>>
>> how is this easier and safer?
>>
>
> The most common way to install firefox is with firefox[-config] and
> run-mozilla.sh in the same dir. This is the most proven layout from
> the mozilla comunity.
The default firefox install installs firefox in bin/firefox
> Doing that, we don't need ${FILESDIR}/patch-browser_app_mozilla.in. =20=
> And
> this really correct a bug.
>
> Also, you may compare /usr/X11R6/bin/mozilla with=20
> /usr/X11R6/bin/firefox
>
> At last here, doing the same or even more, I feel safer with mozilla
> way.
>
> - You don't need to patch mainstream mozilla dist.
> - It's smaller and more clean.
>
> At a minimus, even a simple firefox like:
> #!/bin/sh
> #
>
> exec /usr/X11R6/lib/firefox/firefox
>
> Wil get you a more proven way to launch firefox
>
>>>> | 3) problems with OpenURL()
>>>> |
>>>> | Now, we use a simple REMOTE OpenURL(${url}) that overwrite the
>>>> | displaying page. We use a REMOTE OpenURL(${url},new-tab) in
>>>> | mozilla. we'll use some kinda of MOZILLA_OpenURL_LOC env in
>>>> | firefox/mozilla with the same feel.
>>>>
>>>> Is there a question in here?
>>>
>>> my version of /usr/X11/bin/firefox right now is attached. But I'm
>>> not sure 100%. seems that firefox have config to alter the behavior
>>> of OpenURL(<url>).
>>>
>>> In any way I'll prefer:
>>> - drop ${FILESDIR}/patch-browser_app_mozilla.in (patch is not
>>> needed)
>>
>> you submitted the patch =3DP
>
> Yes. And later see the layout change.
>
> The patch is correct. What I'm talking is about move this stuff to a
> previous script and link both through exec if not using REMOTE.
>
> So we have our FreeBSD related stuff in ${PREFIX}/bin/firefox and the
> mainstream mozilla stuff (without patches) in
> ${PREFIX}/lib/firefox/firefox
This shouldn't matter because before the last commit bin/firefox was=20
linked to lib/firefox/lib/firefox-VERSION/bin/firefox
>>> - install firefox[-config] under ${PREFIX}/lib/firefox
>>
>> Why install firefox[-config] in PREFIX/lib/firefox?
>> I don't see any reason to do this. It's not like we have
>> www/firefox-devel or anything
>> that would conflict.
>
> Please, read above and see how ${PREFIX}/bin/mozilla and
> ${PREFIX}/lib/mozilla/mozilla work in the same way.
The major difference is bin/mozilla script has mail knobs
and firefox doesn't do mail.
>>
>>> - install a brand new ${FILESDIR}/firefox.sh as
>>> ${PREFIX}/bin/firefox
>>
>> So basically the only thing you want is when you open 2 sessions of
>> firefox the
>> 2nd session doesn't open but opens a new tab?
>>
>
> Not really. This may be taken with or without script split.
>
> I can send-pr to what is prefer:
> - more patching to patch-browser_app_mozilla.in
> - script split.
I still don't understand why it's important to install firefox in=20
lib/firefox
and why we can't just edit patch-browser_app_mozilla.in ?
Can you please explain why this is important, I still don't understand=20=
why
installing firefox, firefox-config in lib/firefox is so important, or=20
why it matters?
> Also, if we go to script split, this must reach thunderbird also.
Why?
>> Michael
>
> --
> josemi
--Apple-Mail-3--22227607
content-type: application/pgp-signature; x-mac-type=70674453;
name=PGP.sig
content-description: This is a digitally signed message part
content-disposition: inline; filename=PGP.sig
content-transfer-encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iD8DBQFBmzhWn4uqfTwEb9YRAiWnAJ9kKsZw1agERMrS/d/DbYfdnkQRkgCfTsnS
qRC+ia3kD7ZvD1ZzmWO8TX8=
=1s1H
-----END PGP SIGNATURE-----
--Apple-Mail-3--22227607--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4625EB54-388D-11D9-8B95-000A95BB7150>