Date: Sun, 29 Jul 2007 21:34:54 +0000 From: "R.Mahmatkhanov" <cvs-src@yandex.ru> To: freebsd-usb@freebsd.org Subject: Missing newline in umodem.c Message-ID: <46AD07FE.30501@yandex.ru>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------080200060305070905070102 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Good day! This is cut from my dmesg: """ ucom0: <CURITEL Incorporated CURITEL HX-550C USB Modem, class 2/0, rev 1.10/0.00, addr 2> on uhub1 ucom0: iclass 2/2ucom0: data interface 1, has CM over data, has break ucom0: status change notification available """ There are missing newline after "ucom0: iclass 2/2". This printf is in umodem_attach() from umodem.c:297: device_printf(self, "iclass %d/%d", id->bInterfaceClass, id->bInterfaceSubClass); I beleave we can fix this with patch attached. Can anybody please consider it? --------------080200060305070905070102 Content-Type: text/x-patch; name="umodem.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="umodem.c.diff" --- /usr/src/sys/dev/usb/umodem.c 2007-06-28 14:59:51.000000000 +0000 +++ umodem.c 2007-07-29 21:29:24.000000000 +0000 @@ -294,7 +294,7 @@ sc->sc_ctl_iface = uaa->iface; id = usbd_get_interface_descriptor(sc->sc_ctl_iface); sc->sc_ctl_iface_no = id->bInterfaceNumber; - device_printf(self, "iclass %d/%d", id->bInterfaceClass, + device_printf(self, "iclass %d/%d\n", id->bInterfaceClass, id->bInterfaceSubClass); umodem_get_caps(dev, &sc->sc_cm_cap, &sc->sc_acm_cap); --------------080200060305070905070102--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46AD07FE.30501>