Date: Sun, 05 Aug 2007 22:48:42 +0200 From: Gabor Kovesdan <gabor@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports@FreeBSD.org Subject: Re: PORTSDIR use-before-define fix Message-ID: <46B637AA.1040001@FreeBSD.org> In-Reply-To: <20070805055340.GA11899@rot26.obsecurity.org> References: <20070805055340.GA11899@rot26.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway escribió: > Previous DESTDIR commits introduced dereferences of ${PORTSDIR} before > it was set (via .include), which broke e.g. portmaster. This diff > shuffles some things around to hopefully restore everything to being > defined before it is used. It also cleans up some stale cruft. It > has only been lightly tested. > > I haven't tested it yet, but it seems good to me. Thanks for working on this! I'll test it a bit next day. What about COMMENTFILE? I see it was removed, but can't see it added back. Is it completely obsolete? Regards, -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46B637AA.1040001>