Date: Tue, 09 Nov 2010 22:29:41 -0800 From: Marcel Moolenaar <xcllnt@mac.com> To: Garrett Cooper <gcooper@freebsd.org> Cc: hackers@freebsd.org Subject: Re: [PATCH] Simplify uart_bus_pci_probe Message-ID: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> In-Reply-To: <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com> References: <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: > Some of the logic could have been simplified in the probe. The > proposed patch makes the detection process a tad bit more > straightforward. > Comments, review (and maybe a commit :P) are more than welcome :). The patch is logically wrong for non-ns8250 based UARTs. Leave the code as is. Thanks, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?478E6244-00B4-4D96-93FE-CBD546C27A6E>