Date: Mon, 11 Feb 2008 15:27:04 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Mark Ovens <parish@magichamster.com> Cc: freebsd-ports@freebsd.org Subject: Re: Portmaster ignoring +IGNOREME?? Message-ID: <47B0D9C8.4080105@FreeBSD.org> In-Reply-To: <47B08B18.6060804@magichamster.com> References: <479C872F.3000907@magichamster.com> <479D0000.7080206@FreeBSD.org> <47B08B18.6060804@magichamster.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------050409050702010007010906
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mark Ovens wrote:
> Doug, it's happened again:
It's impossible for me to debug this properly without knowing the
command line options you used. I'm guessing from your description of the
problem that you used at least -r and -u.
> It honoured the +IGNOREME during the recursive ``make config'' but
> failed during the build.
If I understand the problem correctly, the attached patch will fix it.
Please confirm this for me when you can.
> This also highlights a potential problem with portmaster. because it
> prints out all the pkg-message files at the end, and the summary list,
> there is the potential for the reason for the abort to have scrolled out
> of the shell's scrollback buffer (it wasn't far off in this instance)
If you don't use -u, there is a pause between the end of the failed
build and the display of the pkg-message files. If you do use -u it's
assumed that you are able to handle the consequences of doing so.
I actually suggest that people stop using -u, and I am seriously
considering just removing it. It doesn't do what people apparently think
it should do, and it's caused way more trouble than it's worth.
Doug
--
This .signature sanitized for your protection
--------------050409050702010007010906
Content-Type: text/plain;
name="pm-ignore-fix.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="pm-ignore-fix.diff"
--- portmaster 2008/01/30 01:40:33 2.24
+++ portmaster 2008/02/11 23:17:35
@@ -1811,7 +1811,7 @@
fi
;;
esac
- elif [ -n "$NO_RECURSIVE_CONFIG" ]; then
+ elif [ -n "$NO_RECURSIVE_CONFIG" -o -n "$URB_YES" ]; then
echo ''
echo "===>>> $upg_port has an +IGNOREME file, ignoring"
echo ''
--------------050409050702010007010906--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47B0D9C8.4080105>