Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 07 Apr 2008 11:30:11 -0700
From:      LI Xin <delphij@delphij.net>
To:        freebsd-arch@freebsd.org
Cc:        delphij@FreeBSD.ORG
Subject:   Re: [src] cvs commit: src/sys/ufs/ufs ufs_gjournal.c
Message-ID:  <47FA6833.8080904@delphij.net>
In-Reply-To: <20080407181250.6733810656C9@hub.freebsd.org>
References:  <20080407181250.6733810656C9@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0160B57ADC3280A9343DD942
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Picking a random commit:

>   FreeBSD src repository
>=20
>   Modified files:
>     sys/ufs/ufs          ufs_gjournal.c=20
>   Log:
>   Correct function name in panic().
>  =20
>   Reported by:    kensmith
>  =20
>   Revision  Changes    Path
>   1.3       +1 -1      src/sys/ufs/ufs/ufs_gjournal.c
> _______________________________________________
> cvs-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
>=20
>=20
> Index: src/sys/ufs/ufs/ufs_gjournal.c
> diff -u src/sys/ufs/ufs/ufs_gjournal.c:1.2 src/sys/ufs/ufs/ufs_gjournal=
=2Ec:1.3
> --- src/sys/ufs/ufs/ufs_gjournal.c:1.2	Mon May 28 00:28:15 2007
> +++ src/sys/ufs/ufs/ufs_gjournal.c	Mon Apr  7 18:12:37 2008
> @@ -82,7 +82,7 @@
>  		cgbno =3D fsbtodb(fs, cgtod(fs, cg));
>  	}
>  	if ((u_int)ino >=3D fs->fs_ipg * fs->fs_ncg)
> -		panic("ffs_freefile: range: dev =3D %s, ino =3D %lu, fs =3D %s",
> +		panic("ufs_gjournal_modref: range: dev =3D %s, ino =3D %lu, fs =3D %=
s",
>  		    devtoname(dev), (u_long)ino, fs->fs_fsmnt);
>  	if ((error =3D bread(devvp, cgbno, (int)fs->fs_cgsize, NOCRED, &bp)))=
 {
>  		brelse(bp);

Is it suitable to use something like __func__ here?  I mean, will the=20
usage of __func__ encouraged practice for base/kernel code or not?

Cheers,
--=20
Xin LI <delphij@delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!


--------------enig0160B57ADC3280A9343DD942
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH+mgzOfuToMruuMARCmFcAJsEWl5kqDgehV1wWWnbZ1Rdu8smqACfSmvG
/V3tE/pUv/+lUXj51rQge+w=
=8te6
-----END PGP SIGNATURE-----

--------------enig0160B57ADC3280A9343DD942--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47FA6833.8080904>